Page MenuHomePhabricator

Merge target and launch info environments
ClosedPublic

Authored by JDevlieghere on May 13 2019, 10:23 AM.

Details

Diff Detail

Repository
rLLDB LLDB

Event Timeline

JDevlieghere created this revision.May 13 2019, 10:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 13 2019, 10:23 AM
labath accepted this revision.May 13 2019, 10:56 AM

The fix looks good, but it seems like it wouldn't be hard to make the test windows-compatible, so I think we should do that. All it would take is to compile a very dumb version of "env" which just prints the value of the single env var. If you can get it to print in a different format then you can also avoid the double quote trick (which also doesn't work on windows).

Also, doesn't debugging of /usr/bin/env fail on darwin with SIP ?

This revision is now accepted and ready to land.May 13 2019, 10:56 AM
This revision was automatically updated to reflect the committed changes.