Page MenuHomePhabricator

Do not list enabled checks when -quiet is given to run-clang-tidy.
ClosedPublic

Authored by svenpanne on Mon, May 13, 3:28 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

svenpanne created this revision.Mon, May 13, 3:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptMon, May 13, 3:28 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
svenpanne retitled this revision from Do not list enabled checks when -quiet is given to clang-tidy. to Do not list enabled checks when -quiet is given to run-clang-tidy..Mon, May 13, 3:33 AM
svenpanne edited the summary of this revision. (Show Details)
JonasToth accepted this revision.Mon, May 13, 11:31 AM
JonasToth added a subscriber: JonasToth.

LGTM

This revision is now accepted and ready to land.Mon, May 13, 11:31 AM

Thanks for the review. How will the patch be merged? According to https://llvm.org/docs/Phabricator.html#committing-a-change, someone else has to do it for me, because AFAICT, I have no commit rights. As I said: I'm still in the process of learning the workflow here... :-)

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptThu, May 16, 2:20 AM

Yes someone has to do it on behalf of you.
I did so for you. After a view good patches you can get commit rights from chris lattner, until then the reviewer can commit for you.

Thank you for the patch!