Page MenuHomePhabricator

svenpanne (Sven Panne)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 3 2016, 7:33 AM (175 w, 4 d)

Recent Activity

May 16 2019

svenpanne added a comment to D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output..

I think ninja clang-test-tools is the right target here, and it is happy with the change, which is not very surprising: AFAICT, there is just a single, very simple check for run-clang-tidy.py. Anyway, my manual testing with and without -quiet shows no problems, either. Furthermore, we have a patched version with the above change in our CI for quite some time, and it works fine. And if I read the git history correctly, the output should be identical to the one before a fix for interleaved output was landed (that fix added the newlines somehow).

May 16 2019, 4:46 AM · Restricted Project, Restricted Project

May 15 2019

svenpanne added a comment to D61849: Do not list enabled checks when -quiet is given to run-clang-tidy..

Thanks for the review. How will the patch be merged? According to https://llvm.org/docs/Phabricator.html#committing-a-change, someone else has to do it for me, because AFAICT, I have no commit rights. As I said: I'm still in the process of learning the workflow here... :-)

May 15 2019, 11:04 PM · Restricted Project, Restricted Project

May 13 2019

svenpanne added a comment to D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output..

[...] please ensure that e.g. clang-analyzer-* output looks proper as well and -quiet does, too.

May 13 2019, 11:56 AM · Restricted Project, Restricted Project
svenpanne retitled D61849: Do not list enabled checks when -quiet is given to run-clang-tidy. from Do not list enabled checks when -quiet is given to clang-tidy. to Do not list enabled checks when -quiet is given to run-clang-tidy..
May 13 2019, 3:33 AM · Restricted Project, Restricted Project
svenpanne created D61850: Removed superfluous and slightly annoying newlines in run-clang-tidy's output..
May 13 2019, 3:32 AM · Restricted Project, Restricted Project
svenpanne created D61849: Do not list enabled checks when -quiet is given to run-clang-tidy..
May 13 2019, 3:28 AM · Restricted Project, Restricted Project