- User Since
- Aug 3 2016, 7:33 AM (175 w, 4 d)
May 16 2019
I think ninja clang-test-tools is the right target here, and it is happy with the change, which is not very surprising: AFAICT, there is just a single, very simple check for run-clang-tidy.py. Anyway, my manual testing with and without -quiet shows no problems, either. Furthermore, we have a patched version with the above change in our CI for quite some time, and it works fine. And if I read the git history correctly, the output should be identical to the one before a fix for interleaved output was landed (that fix added the newlines somehow).
May 15 2019
Thanks for the review. How will the patch be merged? According to https://llvm.org/docs/Phabricator.html#committing-a-change, someone else has to do it for me, because AFAICT, I have no commit rights. As I said: I'm still in the process of learning the workflow here... :-)