Page MenuHomePhabricator

gn build: add Sparc target
ClosedPublic

Authored by dlj on May 10 2019, 9:44 PM.

Diff Detail

Event Timeline

dlj created this revision.May 10 2019, 9:44 PM
thakis accepted this revision.May 13 2019, 9:57 AM

Nice!

llvm/utils/gn/secondary/llvm/lib/Target/Sparc/MCTargetDesc/BUILD.gn
5

Please give this the https://reviews.llvm.org/D61859 treatment as well.

llvm/utils/gn/secondary/llvm/lib/Target/targets.gni
43

Same comments as in the RISCV CL (again optional).

This revision is now accepted and ready to land.May 13 2019, 9:57 AM
dlj updated this revision to Diff 199362.May 13 2019, 8:58 PM
dlj marked 3 inline comments as done.
dlj added inline comments.
llvm/utils/gn/secondary/llvm/lib/Target/targets.gni
49

D'oh!

(This should have been in the last patch.)