Page MenuHomePhabricator

[libc++] [test] Use std::nextafter() instead of std::nexttoward()
ClosedPublic

Authored by mgorny on May 9 2019, 12:03 PM.

Details

Summary

Use std::nextafter() instead of std::nexttoward() in midpoint tests.
In the context of this test, this should not cause any difference.
Since nexttowardl() is not implemented on NetBSD 8, the latter function
combined with 'long double' type caused test failure. nextafterl() does
not have this problem.

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny created this revision.May 9 2019, 12:03 PM
mclow.lists accepted this revision.May 14 2019, 6:41 AM

I'm ok with this change, but I'm wondering - what is the reason that NetBSD doesn't implement nextafter?

This revision is now accepted and ready to land.May 14 2019, 6:41 AM

It's nexttowardl() that's missing in nb8. I don't really know why, probably nobody needed it at the point (I guess because it's no different than nextafterl()), it was put as TODO and forgotten. I've added it to nb9 but the backport to nb8 is currently blocked on some ABI stability debate. Until that's resolved, and since it doesn't seem to make any difference here, the change makes it possible to make tests pass again.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2019, 6:55 AM