This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Make builtins test pass when using i386 gcc as host compiler
ClosedPublic

Authored by thakis on May 8 2019, 8:40 AM.

Details

Summary

Just-built-clang is used to compile the test, but the library is built with gcc, so the usual 80-bit FPU vs 32-bit SSE mismatch makes the floating computations not bitwise identical. See PR32910 for details.

This uses the same technique used in all the other *c3* tests, see in particular mulsc3_test.c.

(It might be cleaner to add compareResultCF to fp_test.h to force the floats into 32-bit in memory, but this is the less invasive fix.)

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.May 8 2019, 8:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 8 2019, 8:40 AM
Herald added a subscriber: dberris. · View Herald Transcript
hans accepted this revision.May 8 2019, 8:44 AM
This revision is now accepted and ready to land.May 8 2019, 8:44 AM
This revision was automatically updated to reflect the committed changes.