This is an archive of the discontinued LLVM Phabricator instance.

Differential D61605

Fix a typo
ClosedPublic

Authored by yan_luo on May 6 2019, 11:22 AM.

Details

Reviewers
stoklund
craig.topper
hfinkel
Commits
rZORG31105cad8bb8: [TableGen] Fix a typo
rZORG557385e5178e: [TableGen] Fix a typo
rG31105cad8bb8: [TableGen] Fix a typo
rG557385e5178e: [TableGen] Fix a typo
rG55ed2f53095f: [TableGen] Fix a typo
rL360106: [TableGen] Fix a typo
Summary

Check B instead of S in the second condition.

Diff Detail

Repository
rL LLVM

Event Timeline

yan_luo created this revision.May 6 2019, 11:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2019, 11:22 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
yan_luo added reviewers: craig.topper, hfinkel.May 6 2019, 2:41 PM
craig.topper accepted this revision.May 6 2019, 4:46 PM

LGTM

This revision is now accepted and ready to land.May 6 2019, 4:46 PM
Closed by commit rL360106: [TableGen] Fix a typo (authored by yanluo). · Explain WhyMay 6 2019, 6:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
utils/
TableGen/
2 lines

Diff 198383

llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp

Show First 20 Lines • Show All 473 Lines • ▼ Show 20 Linesbool TypeInfer::EnforceSmallerThan(TypeSetByHwMode &Small,
// 1. Only allow integer or floating point types and make sure that // 1. Only allow integer or floating point types and make sure that
// both sides are both integer or both floating point. // both sides are both integer or both floating point.
// 2. Make sure that either both sides have vector types, or neither // 2. Make sure that either both sides have vector types, or neither
// of them does. // of them does.
for (unsigned M : Modes) { for (unsigned M : Modes) {
TypeSetByHwMode::SetType &S = Small.get(M); TypeSetByHwMode::SetType &S = Small.get(M);
TypeSetByHwMode::SetType &B = Big.get(M); TypeSetByHwMode::SetType &B = Big.get(M);
if (any_of(S, isIntegerOrPtr) && any_of(S, isIntegerOrPtr)) { if (any_of(S, isIntegerOrPtr) && any_of(B, isIntegerOrPtr)) {
auto NotInt = [](MVT VT) { return !isIntegerOrPtr(VT); }; auto NotInt = [](MVT VT) { return !isIntegerOrPtr(VT); };
Changed |= berase_if(S, NotInt) | Changed |= berase_if(S, NotInt) |
berase_if(B, NotInt); berase_if(B, NotInt);
} else if (any_of(S, isFloatingPoint) && any_of(B, isFloatingPoint)) { } else if (any_of(S, isFloatingPoint) && any_of(B, isFloatingPoint)) {
auto NotFP = [](MVT VT) { return !isFloatingPoint(VT); }; auto NotFP = [](MVT VT) { return !isFloatingPoint(VT); };
Changed |= berase_if(S, NotFP) | Changed |= berase_if(S, NotFP) |
berase_if(B, NotFP); berase_if(B, NotFP);
} else if (S.empty() || B.empty()) { } else if (S.empty() || B.empty()) {
▲ Show 20 Lines • Show All 4,138 Lines • Show Last 20 Lines