User Details
- User Since
- Mar 20 2018, 3:03 PM (297 w, 1 d)
May 6 2019
Mar 13 2019
LGTM
Mar 7 2019
Updated the diff.
Only need to check mayStore() on DI.
Mar 6 2019
It seems that Hexagon is the only target that is using SWP in the upstream. Not sure a reproducible testcase at our side is also reproducible in the Hexagon target. But I will give it a try.
Currently I only have an in-house benchmark for this. Not sure I can share this, but if Brendon confirms this is a correct fix, I will try to come up with a reproducible testcase.
Apr 13 2018
Thanks for the review! It is landed in r330031.
Apr 12 2018
I updated the diff, please review it again, thanks!
Apr 6 2018
Thanks for your review!
Apr 4 2018
Yes, Pete. Please land it for me. Thanks!
Apr 3 2018
Pete, I updated the revision, please review it again, thanks!
Apr 1 2018
Mar 27 2018
BTW, I don't have commit access. Can you please help me land this fix? Thanks!
Mar 26 2018
Thanks! I updated the diff, please review it again.
I just copied and pasted the result of 'git diff'. Any step I should follow? First time use, sorry!