Page MenuHomePhabricator

[NFC] Modernize repmovsb implementation of x86 memcpy.
ClosedPublic

Authored by gchatelet on May 6 2019, 6:30 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

gchatelet created this revision.May 6 2019, 6:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2019, 6:30 AM
gchatelet updated this revision to Diff 198264.May 6 2019, 6:39 AM
  • Fix typo.
courbet added inline comments.May 6 2019, 7:14 AM
llvm/lib/Target/X86/X86SelectionDAGInfo.cpp
319 ↗(On Diff #198261)

Let's do this as a separate change with a test to show the change in behaviour

gchatelet updated this revision to Diff 198277.May 6 2019, 7:19 AM
  • Turn this patch into an NFC.
gchatelet retitled this revision from Modernize repmovsb implementation of x86 memcpy and allow runtime sizes. to [NFC] Modernize repmovsb implementation of x86 memcpy..May 6 2019, 7:19 AM
gchatelet marked an inline comment as done.
courbet accepted this revision.May 6 2019, 7:43 AM

Only nits.

llvm/lib/Target/X86/X86SelectionDAGInfo.cpp
215 ↗(On Diff #198277)

s/regarding/depending on/

242 ↗(On Diff #198277)

march ?

This revision is now accepted and ready to land.May 6 2019, 7:43 AM
gchatelet updated this revision to Diff 198279.May 6 2019, 7:57 AM
gchatelet marked 2 inline comments as done.
  • Addressing comments
gchatelet updated this revision to Diff 198280.May 6 2019, 8:00 AM
  • Addressing comments
Harbormaster completed remote builds in B31454: Diff 198280.
This revision was automatically updated to reflect the committed changes.