Page MenuHomePhabricator

Make sub-registers index names case sensitive in the MIRParser
ClosedPublic

Authored by markus on May 3 2019, 6:16 AM.

Details

Summary

Prior to this change sub-register index names are assumed to be lower case (but they are printed with original casing). This means that if a target has some upper case characters in its sub-register names then mir-export directly followed by mir-import is not possible. This also means that sub-register indices currently are (and will continue to be) slightly inconsistent with register names which are printed and assumed to be lower case.

As the current textual representation of mir has a few inconsistencies in this area it is a bit arbitrary how to address this but the suggested change is towards the direction that we feel is most correct (i.e. case sensitivity).

Diff Detail

Repository
rL LLVM

Event Timeline

markus created this revision.May 3 2019, 6:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2019, 6:16 AM
bjope accepted this revision.May 7 2019, 6:01 AM

LGTM!

This revision is now accepted and ready to land.May 7 2019, 6:01 AM
This revision was automatically updated to reflect the committed changes.