This is an archive of the discontinued LLVM Phabricator instance.

Added an AST matcher for declarations that are in the `std` namespace
ClosedPublic

Authored by gribozavr on May 3 2019, 1:05 AM.

Diff Detail

Event Timeline

gribozavr created this revision.May 3 2019, 1:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2019, 1:05 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaron.ballman requested changes to this revision.May 3 2019, 1:15 AM
aaron.ballman added a subscriber: aaron.ballman.

You should also update Registry.cpp to add this to clang-query and you should also regenerate the documentation by running clang\docs\tools\dump_ast_matchers.py.

clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp
2079 ↗(On Diff #197925)

Can you also add a negative test case for:

namespace foo {
namespace std {
  void bar(); // isInStdNamespace() is false here, right?
}
}
This revision now requires changes to proceed.May 3 2019, 1:15 AM
alexfh added a comment.May 3 2019, 1:57 AM

Please regenerate the HTML docs using clang/docs/tools/dump_ast_matchers.py.

gribozavr updated this revision to Diff 197950.May 3 2019, 3:57 AM

Regenerated documentation and added one more test

gribozavr marked 2 inline comments as done.May 3 2019, 3:58 AM
gribozavr added inline comments.
clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp
2079 ↗(On Diff #197925)

Done.

This revision is now accepted and ready to land.May 3 2019, 5:24 AM
This revision was automatically updated to reflect the committed changes.
gribozavr marked an inline comment as done.