Page MenuHomePhabricator

[MemorySSA] Refactor removing multiple trivial phis [NFC].
ClosedPublic

Authored by asbirlea on May 2 2019, 3:37 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

asbirlea created this revision.May 2 2019, 3:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2019, 3:37 PM
Herald added subscribers: Prazek, jlebar. · View Herald Transcript
george.burgess.iv accepted this revision.May 2 2019, 3:42 PM

LGTM after two nits; thanks!

lib/Analysis/MemorySSAUpdater.cpp
358 ↗(On Diff #197881)

nit: unsigned please, to match with the type of the RHS

360 ↗(On Diff #197881)

nit: (parens) around InsertedPHIs[NewPhiIndex] are unnecessary; please remove

This revision is now accepted and ready to land.May 2 2019, 3:42 PM
asbirlea updated this revision to Diff 197886.May 2 2019, 4:01 PM
asbirlea marked 2 inline comments as done.

Address comments. Thank you for the review!

This revision was automatically updated to reflect the committed changes.