This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
cfe/trunk/lib/Basic/Targets/
-
trunk/
-
lib/
-
Basic/
-
Targets/
-
RISCV.cpp

Differential D61464

[RiscV] Typo in register aliases
ClosedPublic

Authored by JohnLLVM on May 2 2019, 2:02 PM.

Download Raw Diff

Details

Reviewers

asb
echristo

Commits

rZORG081da0d428d3: Fix typo in risc-v register aliases.
rZORG8587eacb049b: Fix typo in risc-v register aliases.
rG081da0d428d3: Fix typo in risc-v register aliases.
rG8587eacb049b: Fix typo in risc-v register aliases.
rGe2b7332d2d9f: Fix typo in risc-v register aliases.
rC360104: Fix typo in risc-v register aliases.
rL360104: Fix typo in risc-v register aliases.

Summary

Not much to say, this typo did break inline assembly routines.

@echristo: I have no idea who to put as reviewer. Putting your name as there is "inline assembly" in CODE_OWNERS.txt. Do not hesitate to put someone else instead.

Diff Detail

Repository: rL LLVM

Event Timeline

JohnLLVM created this revision.May 2 2019, 2:02 PM

Herald added subscribers: cfe-commits, benna, psnobl and 19 others. · View Herald TranscriptMay 2 2019, 2:02 PM

Proper context.

jrtc27 edited reviewers, added: asb; removed: echristo.May 2 2019, 5:03 PM

Ouch; LGTM.

LGTM. Sorry I didn't notice this earlier.

-eric

This revision is now accepted and ready to land.May 2 2019, 5:07 PM

What should I do now? I do not have rights to commit.

Closed by commit rL360104: Fix typo in risc-v register aliases. (authored by echristo). · Explain WhyMay 6 2019, 5:44 PM

This revision was automatically updated to reflect the committed changes.

Herald added a project: Restricted Project. · View Herald TranscriptMay 6 2019, 5:44 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

Path

Size

cfe/

trunk/

lib/

Basic/

Targets/

RISCV.cpp

2 lines

Diff 198382

cfe/trunk/lib/Basic/Targets/RISCV.cpp

Show All 25 Lines	ArrayRef<const char *> RISCVTargetInfo::getGCCRegNames() const {
return llvm::makeArrayRef(GCCRegNames);		return llvm::makeArrayRef(GCCRegNames);
}		}

ArrayRef<TargetInfo::GCCRegAlias> RISCVTargetInfo::getGCCRegAliases() const {		ArrayRef<TargetInfo::GCCRegAlias> RISCVTargetInfo::getGCCRegAliases() const {
static const TargetInfo::GCCRegAlias GCCRegAliases[] = {		static const TargetInfo::GCCRegAlias GCCRegAliases[] = {
{{"zero"}, "x0"}, {{"ra"}, "x1"}, {{"sp"}, "x2"}, {{"gp"}, "x3"},		{{"zero"}, "x0"}, {{"ra"}, "x1"}, {{"sp"}, "x2"}, {{"gp"}, "x3"},
{{"tp"}, "x4"}, {{"t0"}, "x5"}, {{"t1"}, "x6"}, {{"t2"}, "x7"},		{{"tp"}, "x4"}, {{"t0"}, "x5"}, {{"t1"}, "x6"}, {{"t2"}, "x7"},
{{"s0"}, "x8"}, {{"s1"}, "x9"}, {{"a0"}, "x10"}, {{"a1"}, "x11"},		{{"s0"}, "x8"}, {{"s1"}, "x9"}, {{"a0"}, "x10"}, {{"a1"}, "x11"},
{{"a2"}, "x12"}, {{"a3"}, "x13"}, {{"a4"}, "x15"}, {{"a5"}, "x15"},		{{"a2"}, "x12"}, {{"a3"}, "x13"}, {{"a4"}, "x14"}, {{"a5"}, "x15"},
{{"a6"}, "x16"}, {{"a7"}, "x17"}, {{"s2"}, "x18"}, {{"s3"}, "x19"},		{{"a6"}, "x16"}, {{"a7"}, "x17"}, {{"s2"}, "x18"}, {{"s3"}, "x19"},
{{"s4"}, "x20"}, {{"s5"}, "x21"}, {{"s6"}, "x22"}, {{"s7"}, "x23"},		{{"s4"}, "x20"}, {{"s5"}, "x21"}, {{"s6"}, "x22"}, {{"s7"}, "x23"},
{{"s8"}, "x24"}, {{"s9"}, "x25"}, {{"s10"}, "x26"}, {{"s11"}, "x27"},		{{"s8"}, "x24"}, {{"s9"}, "x25"}, {{"s10"}, "x26"}, {{"s11"}, "x27"},
{{"t3"}, "x28"}, {{"t4"}, "x29"}, {{"t5"}, "x30"}, {{"t6"}, "x31"}};		{{"t3"}, "x28"}, {{"t4"}, "x29"}, {{"t5"}, "x30"}, {{"t6"}, "x31"}};
return llvm::makeArrayRef(GCCRegAliases);		return llvm::makeArrayRef(GCCRegAliases);
}		}

void RISCVTargetInfo::getTargetDefines(const LangOptions &Opts,		void RISCVTargetInfo::getTargetDefines(const LangOptions &Opts,
▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines