Page MenuHomePhabricator

[lldb] [lit] Add write tests for AVX-512 registers (zmm, xmm15+, ymm15+)
ClosedPublic

Authored by mgorny on May 2 2019, 6:11 AM.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

mgorny created this revision.May 2 2019, 6:11 AM
mgorny updated this revision to Diff 197772.May 2 2019, 6:58 AM
mgorny retitled this revision from [lldb] [lit] Add write tests for ZMM registers to [lldb] [lit] Add write tests for AVX-512 registers (zmm, xmm15+, ymm15+).

Added xmm15+ and ymm15+ tests.

labath accepted this revision.May 2 2019, 8:58 AM

The tests look fine to me, but given that mac doesn't support writing to ymm registers, I'd be surprised if these were to pass too (so I'd add system-darwin to the list of XFAILs too).

At that point, we've run out of systems where this test can possibly pass, so it's kinda hard to check that it is written correctly, but since you've went through the trouble of writing it, I suppose we can include it here for future reference.

This revision is now accepted and ready to land.May 2 2019, 8:58 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2019, 9:08 AM
Herald added a subscriber: teemperor. · View Herald Transcript
mgorny added a comment.May 2 2019, 9:08 AM

Thanks. Now you'll have proper motivation to add AVX-512 support to Linux ;-).