This is an archive of the discontinued LLVM Phabricator instance.

Another attempt to fix "could not find clang-check" lit warning in analyzer-less builds
ClosedPublic

Authored by thakis on May 1 2019, 6:55 PM.

Details

Summary

r359717 added clang-check as a dep of check-clang unconditionally because I had missed lit.local.cfg in test/Tooling.

Instead, only add clang-check to the tools if the analyzer is enabled, since the build target only exists then, and since all tests using clang-check are skipped when the analyzer is disabled.

Diff Detail

Event Timeline

thakis created this revision.May 1 2019, 6:55 PM
rnk accepted this revision.May 2 2019, 11:24 AM

lgtm

This revision is now accepted and ready to land.May 2 2019, 11:24 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2019, 12:44 PM