This is an archive of the discontinued LLVM Phabricator instance.

Differential D61394

Remove unnecessary check in SymbolFileDWARF::ParseImportedModules
ClosedPublic

Authored by teemperor on May 1 2019, 12:17 PM.

Details

Reviewers
aprantl
Commits
rG21db1440f9b2: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules
rL359813: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules
rLLDB359813: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules
Summary

This check seems unnecessary as we already assert the same condition above and also access sc.comp_unit
before this check.

Diff Detail

Event Timeline

teemperor created this revision.May 1 2019, 12:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 1 2019, 12:17 PM
Herald added subscribers: lldb-commits, jdoerfert. · View Herald Transcript
aprantl accepted this revision.May 2 2019, 11:21 AM

True.

This revision is now accepted and ready to land.May 2 2019, 11:21 AM
Closed by commit rL359813: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules (authored by teemperor). · Explain WhyMay 2 2019, 11:24 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 2 2019, 11:24 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
lldb/
source/
Plugins/
SymbolFile/
DWARF/
3 lines

Diff 197607

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Show First 20 Lines • Show All 903 Lines • ▼ Show 20 Linesbool SymbolFileDWARF::ParseImportedModules(
DWARFUnit *dwarf_cu = GetDWARFCompileUnit(sc.comp_unit); DWARFUnit *dwarf_cu = GetDWARFCompileUnit(sc.comp_unit);
if (!dwarf_cu) if (!dwarf_cu)
return false; return false;
if (!ClangModulesDeclVendor::LanguageSupportsClangModules( if (!ClangModulesDeclVendor::LanguageSupportsClangModules(
sc.comp_unit->GetLanguage())) sc.comp_unit->GetLanguage()))
return false; return false;
UpdateExternalModuleListIfNeeded(); UpdateExternalModuleListIfNeeded();
if (!sc.comp_unit)
return false;
const DWARFDIE die = dwarf_cu->DIE(); const DWARFDIE die = dwarf_cu->DIE();
if (!die) if (!die)
return false; return false;
for (DWARFDIE child_die = die.GetFirstChild(); child_die; for (DWARFDIE child_die = die.GetFirstChild(); child_die;
child_die = child_die.GetSibling()) { child_die = child_die.GetSibling()) {
if (child_die.Tag() != DW_TAG_imported_declaration) if (child_die.Tag() != DW_TAG_imported_declaration)
continue; continue;
▲ Show 20 Lines • Show All 2,914 Lines • Show Last 20 Lines