Details
- Reviewers
mclow.lists EricWF ldionne
Diff Detail
Event Timeline
test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp | ||
---|---|---|
159 | This will blow up non-MSVC-ish when running the test suite with -Wall -W -Werror (which is typical). I suggest wrapping in #ifdef _MSC_VER. |
test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp | ||
---|---|---|
159 | Why didn't it blow up on Contest then? clang-cl is happy with it? |
test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp | ||
---|---|---|
159 | clang-cl is the "ish" in my "MSVC-ish" (MSVC and compilers emulating MSVC). GCC and clang-without--fms-compatibility when compiling with -Wall warn about unrecognized pragmas, just as does cl in default mode (https://godbolt.org/z/Chue0L). |
test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp | ||
---|---|---|
159 | Correction: Wrap with #ifdef TEST_COMPILER_C1XX instead of #ifdef _MSC_VER. |
This will blow up non-MSVC-ish when running the test suite with -Wall -W -Werror (which is typical). I suggest wrapping in #ifdef _MSC_VER.