This is an archive of the discontinued LLVM Phabricator instance.

Make check-clang depend on the clang-check binary always
ClosedPublic

Authored by thakis on Apr 30 2019, 10:31 AM.

Details

Summary

check-clang (the target that runs all clang tests) used to
only depend on clang-check (a binary like clang-tidy,
clang-refactor, etc) if the static analyzer is enabled.
However, several lit tests call clang-check unconditionally,
so always depend on it.

Fixes a "could not find clang-check" lit warning in clean builds with
the static analyzer disabled.

Also sort the deps in the CMake file and put just one dep on each line.

Diff Detail

Event Timeline

thakis created this revision.Apr 30 2019, 10:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 30 2019, 10:31 AM
rnk accepted this revision.May 1 2019, 11:15 AM

lgtm

This revision is now accepted and ready to land.May 1 2019, 11:15 AM
This revision was automatically updated to reflect the committed changes.