This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Portability fix: std::regex_constants::error_type values are not requied to be non-zero.

Authored by amakc11 on Apr 26 2019, 8:42 AM.



The standard requires the following for the std::regex_constants::error_type values: "The type error_­type is an implementation-defined enumerated type". The values of this enumerated type are not required to be non-zero. This patch makes such checks in tests libc++-specific to let the tests pass for other conforming implementations.

Diff Detail


Event Timeline

amakc11 created this revision.Apr 26 2019, 8:42 AM
ldionne accepted this revision.Apr 26 2019, 9:22 AM
This revision is now accepted and ready to land.Apr 26 2019, 9:22 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2019, 9:45 AM