This is an archive of the discontinued LLVM Phabricator instance.

Differential D61177

[MinGW] Always emit local typeinfo
ClosedPublic

Authored by mstorsjo on Apr 26 2019, 12:50 AM.

Details

Reviewers
rnk
hans
smeenai
Commits
rG228ccd675484: [MinGW] Always emit local typeinfo
rL359345: [MinGW] Always emit local typeinfo
rC359345: [MinGW] Always emit local typeinfo
Summary

This makes sure that code built with headers for a statically linked libc++ also works when linking to the DLL version, when the DLL hasn't been built with --export-all-symbols.

This matches what GCC for MinGW does for this test case.

Diff Detail

Event Timeline

mstorsjo created this revision.Apr 26 2019, 12:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2019, 12:50 AM
hans accepted this revision.Apr 26 2019, 2:11 AM

lgtm

This revision is now accepted and ready to land.Apr 26 2019, 2:11 AM
Closed by commit rC359345: [MinGW] Always emit local typeinfo (authored by mstorsjo). · Explain WhyApr 26 2019, 12:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
CodeGen/
2 lines
test/
CodeGenCXX/
10 lines

Diff 196813

lib/CodeGen/ItaniumCXXABI.cpp

Show First 20 Lines • Show All 991 Lines • ▼ Show 20 Lines
// FIXME: this may need to be reconsidered if the key function // FIXME: this may need to be reconsidered if the key function
// changes. // changes.
// N.B. We must always emit the RTTI data ourselves if there exists a key // N.B. We must always emit the RTTI data ourselves if there exists a key
// function. // function.
bool IsDLLImport = RD->hasAttr<DLLImportAttr>(); bool IsDLLImport = RD->hasAttr<DLLImportAttr>();
// Don't import the RTTI but emit it locally. // Don't import the RTTI but emit it locally.
if (CGM.getTriple().isWindowsGNUEnvironment() && IsDLLImport) if (CGM.getTriple().isWindowsGNUEnvironment())
return false; return false;
if (CGM.getVTables().isVTableExternal(RD)) if (CGM.getVTables().isVTableExternal(RD))
return IsDLLImport && !CGM.getTriple().isWindowsItaniumEnvironment() return IsDLLImport && !CGM.getTriple().isWindowsItaniumEnvironment()
? false ? false
: true; : true;
if (IsDLLImport) if (IsDLLImport)
▲ Show 20 Lines • Show All 991 Lines • Show Last 20 Lines

test/CodeGenCXX/vtable-key-function-ios.cpp

// RUN: %clang_cc1 %s -triple=armv7-apple-darwin -emit-llvm -o - | FileCheck %s // RUN: %clang_cc1 %s -triple=armv7-apple-darwin -emit-llvm -o - | FileCheck -check-prefixes=CHECK,CHECK-UNIX %s
// RUN: %clang_cc1 %s -triple=armv7-apple-darwin -emit-llvm -o - | FileCheck -check-prefix=CHECK-LATE %s // RUN: %clang_cc1 %s -triple=armv7-apple-darwin -emit-llvm -o - | FileCheck -check-prefix=CHECK-LATE %s
// RUN: %clang_cc1 %s -triple=x86_64-pc-windows-gnu -emit-llvm -o - | FileCheck %s // RUN: %clang_cc1 %s -triple=x86_64-pc-windows-gnu -emit-llvm -o - | FileCheck -check-prefixes=CHECK,CHECK-MINGW %s
// RUN: %clang_cc1 %s -triple=x86_64-pc-windows-gnu -emit-llvm -o - | FileCheck -check-prefix=CHECK-LATE %s // RUN: %clang_cc1 %s -triple=x86_64-pc-windows-gnu -emit-llvm -o - | FileCheck -check-prefix=CHECK-LATE %s
// The 'a' variants ask for the vtable first. // The 'a' variants ask for the vtable first.
// The 'b' variants ask for the vtable second. // The 'b' variants ask for the vtable second.
// The 'c' variants ask for the vtable third. // The 'c' variants ask for the vtable third.
// We do a separate CHECK-LATE pass because the RTTI definition gets // We do a separate CHECK-LATE pass because the RTTI definition gets
// changed after the fact, which causes reordering of the globals. // changed after the fact, which causes reordering of the globals.
Show All 11 Linesstruct Test0a {
Test0a(); Test0a();
virtual inline void foo(); virtual inline void foo();
virtual void bar(); virtual void bar();
}; };
// V-table should be defined externally. // V-table should be defined externally.
Test0a::Test0a() { use(typeid(Test0a)); } Test0a::Test0a() { use(typeid(Test0a)); }
// CHECK: @_ZTV6Test0a = external {{(dso_local )?}}unnamed_addr constant // CHECK: @_ZTV6Test0a = external {{(dso_local )?}}unnamed_addr constant
// CHECK: @_ZTI6Test0a = external {{(dso_local )?}}constant // CHECK-UNIX: @_ZTI6Test0a = external {{(dso_local )?}}constant
// CHECK-MINGW: @_ZTI6Test0a = linkonce_odr {{(dso_local )?}}constant
// This is not a key function. // This is not a key function.
void Test0a::foo() {} void Test0a::foo() {}
/*** Test0b ******************************************************************/ /*** Test0b ******************************************************************/
struct Test0b { struct Test0b {
Test0b(); Test0b();
virtual inline void foo(); virtual inline void foo();
virtual void bar(); virtual void bar();
}; };
// This is not a key function. // This is not a key function.
void Test0b::foo() {} void Test0b::foo() {}
// V-table should be defined externally. // V-table should be defined externally.
Test0b::Test0b() { use(typeid(Test0b)); } Test0b::Test0b() { use(typeid(Test0b)); }
// CHECK: @_ZTV6Test0b = external {{(dso_local )?}}unnamed_addr constant // CHECK: @_ZTV6Test0b = external {{(dso_local )?}}unnamed_addr constant
// CHECK: @_ZTI6Test0b = external {{(dso_local )?}}constant // CHECK-UNIX: @_ZTI6Test0b = external {{(dso_local )?}}constant
// CHECK-MINGW: @_ZTI6Test0b = linkonce_odr {{(dso_local )?}}constant
/*** Test1a ******************************************************************/ /*** Test1a ******************************************************************/
struct Test1a { struct Test1a {
Test1a(); Test1a();
virtual void foo(); virtual void foo();
virtual void bar(); virtual void bar();
}; };
▲ Show 20 Lines • Show All 133 Lines • Show Last 20 Lines