This is an archive of the discontinued LLVM Phabricator instance.

Differential D61142

Set LoopInterleaved in the PassManagerBuilder.
ClosedPublic

Authored by asbirlea on Apr 25 2019, 11:45 AM.

Details

Reviewers
chandlerc
Commits
rGa9b9ab8bfd4f: Set LoopInterleaved in the PassManagerBuilder.
rL359616: Set LoopInterleaved in the PassManagerBuilder.
rC359616: Set LoopInterleaved in the PassManagerBuilder.
Summary

Corresponds to D61030.

Diff Detail

Repository
rC Clang

Event Timeline

asbirlea created this revision.Apr 25 2019, 11:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 25 2019, 11:45 AM
Herald added subscribers: cfe-commits, jlebar. · View Herald Transcript
Harbormaster completed remote builds in B31007: Diff 196696.Apr 25 2019, 11:45 AM
asbirlea mentioned this in D61030: [PassManagerBuilder] Add option for interleaved loops, for loop vectorize..Apr 29 2019, 5:03 PM
chandlerc accepted this revision.Apr 29 2019, 5:27 PM
chandlerc added a subscriber: chandlerc.

LGTM, maybe add a comment here to archive some of the reasoning? (IE, that when unrolling is disabled we disable both literal unrolling but also interleaving for historical reasons)

This revision is now accepted and ready to land.Apr 29 2019, 5:27 PM
Closed by commit rC359616: Set LoopInterleaved in the PassManagerBuilder. (authored by asbirlea). · Explain WhyApr 30 2019, 2:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
CodeGen/
3 lines

Diff 197445

lib/CodeGen/BackendUtil.cpp

Show First 20 Lines • Show All 554 Lines • ▼ Show 20 Linesvoid EmitAssemblyHelper::CreatePasses(legacy::PassManager &MPM,
} }
PMBuilder.OptLevel = CodeGenOpts.OptimizationLevel; PMBuilder.OptLevel = CodeGenOpts.OptimizationLevel;
PMBuilder.SizeLevel = CodeGenOpts.OptimizeSize; PMBuilder.SizeLevel = CodeGenOpts.OptimizeSize;
PMBuilder.SLPVectorize = CodeGenOpts.VectorizeSLP; PMBuilder.SLPVectorize = CodeGenOpts.VectorizeSLP;
PMBuilder.LoopVectorize = CodeGenOpts.VectorizeLoop; PMBuilder.LoopVectorize = CodeGenOpts.VectorizeLoop;
PMBuilder.DisableUnrollLoops = !CodeGenOpts.UnrollLoops; PMBuilder.DisableUnrollLoops = !CodeGenOpts.UnrollLoops;
// Loop interleaving in the loop vectorizer has historically been set to be
// enabled when loop unrolling is enabled.
PMBuilder.LoopsInterleaved = CodeGenOpts.UnrollLoops;
PMBuilder.MergeFunctions = CodeGenOpts.MergeFunctions; PMBuilder.MergeFunctions = CodeGenOpts.MergeFunctions;
PMBuilder.PrepareForThinLTO = CodeGenOpts.PrepareForThinLTO; PMBuilder.PrepareForThinLTO = CodeGenOpts.PrepareForThinLTO;
PMBuilder.PrepareForLTO = CodeGenOpts.PrepareForLTO; PMBuilder.PrepareForLTO = CodeGenOpts.PrepareForLTO;
PMBuilder.RerollLoops = CodeGenOpts.RerollLoops; PMBuilder.RerollLoops = CodeGenOpts.RerollLoops;
MPM.add(new TargetLibraryInfoWrapperPass(*TLII)); MPM.add(new TargetLibraryInfoWrapperPass(*TLII));
if (TM) if (TM)
▲ Show 20 Lines • Show All 1,019 Lines • Show Last 20 Lines