Page MenuHomePhabricator

llvm-nm and llvm-objcopy belong to toolchain

Authored by jiangyi on Apr 24 2019, 12:08 PM.


Diff Detail


Event Timeline

jiangyi created this revision.Apr 24 2019, 12:08 PM
Herald added a project: Restricted Project. · View Herald Transcript
alexshap accepted this revision.Apr 25 2019, 11:59 PM
This revision is now accepted and ready to land.Apr 25 2019, 11:59 PM

Ping. Does anyone have permission to commit this?

  1. patches which are meant to be sent for code review should include "full context"
  2. I think it'd be useful to flash out the description of this change (why you are changing this / what does this fix, even if the change is small)

my understanding is that you are trying to change LLVM_TOOLCHAIN_TOOLS - is it correct ?

  1. I will add one more reviewer to have a look at this diff (just in case).
compnerd accepted this revision.Jun 3 2019, 10:06 AM
compnerd closed this revision.Jun 3 2019, 10:14 AM

SVN r362425