Static chunked OpenMP scheduling has not been treated correctly.
This patch fixes the problem that threads would not process their (work-)chunks as intended.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
lib/CodeGen/LoopGeneratorsGOMP.cpp | ||
---|---|---|
76–80 ↗ | (On Diff #196490) | [nit] unrelated? |
lib/CodeGen/LoopGeneratorsKMP.cpp | ||
219–220 ↗ | (On Diff #196490) | Are these renames related to the patch? If not, can you undo them? It would make the diff smaller, especially reduces the changed lines in the test case to the ones that are relevant. |
test/Isl/CodeGen/OpenMP/single_loop.ll | ||
7 ↗ | (On Diff #196490) | [serious] Since they are significantly different, there should be a test for -polly-scheduling=static without chunksize as well. |
lib/CodeGen/LoopGeneratorsKMP.cpp | ||
---|---|---|
219–220 ↗ | (On Diff #196490) | Not really, I wanted to be closer to the naming of the original backend. |
test/Isl/CodeGen/OpenMP/single_loop.ll | ||
7 ↗ | (On Diff #196490) | Done. (Thought about it, too.) |
LGTM. Can I commit for you?
That would be great -- thank you!
(Hopefully, I catched everything this time :) )
Sorry for the delay, I was really busy the last weeks.
That's absolutely fine by me, no worries.
I just wanted to make sure this patch was not forgotten or overlooked.
Sorry, I completely missed that I did not commit this yet. Without ping, I would not have noticed. It's committed now. Thanks for your contribution!