|65 ↗||(On Diff #196461)|
AFAICS from other helpers, ValueIsMatcher should go in llvm::detail, and ValueIs should go in llvm.
unittest::getInputFileDirectory() reads well, but unittest::ValueIs(...) really doesn't...
|85 ↗||(On Diff #196461)|
is this actually necessary? I think it's already going to print the value, which is always "None" - I'm not sure "None, which does not have a value" is clearer.
|109 ↗||(On Diff #196461)|
it's a shame the name HasValue is taken, as I think it would much more clearly communicate "has a value *and* the value is...".