This is an archive of the discontinued LLVM Phabricator instance.

Differential D60948

yamlify TestMiniDumpUUID binaries
ClosedPublic

Authored by labath on Apr 21 2019, 6:15 AM.

Details

Reviewers
clayborg
Commits
rGed4f48d290e3: yamlify TestMiniDumpUUID binaries
rL358957: yamlify TestMiniDumpUUID binaries
rLLDB358957: yamlify TestMiniDumpUUID binaries
Summary

Instead of checking in raw minidump binaries, check in their yaml form,
and call yaml2obj in the test.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

labath created this revision.Apr 21 2019, 6:15 AM
Herald added a subscriber: javed.absar. · View Herald TranscriptApr 21 2019, 6:15 AM
labath marked an inline comment as done.Apr 21 2019, 6:17 AM
labath added inline comments.
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-zero-uuids.yaml
6

@clayborg: The OS in this minidump is inconsistent with the file name. Do you want me to rename the file, or change the OS in the minidump?

Harbormaster completed remote builds in B30816: Diff 196000.Apr 21 2019, 6:18 AM
clayborg accepted this revision.Apr 22 2019, 7:13 AM
clayborg added inline comments.
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-zero-uuids.yaml
6

Lets change the OS

This revision is now accepted and ready to land.Apr 22 2019, 7:13 AM
Closed by commit rLLDB358957: yamlify TestMiniDumpUUID binaries (authored by labath). · Explain WhyApr 23 2019, 1:47 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2019, 1:47 AM
Herald added a subscriber: abidh. · View Herald Transcript

Revision Contents

Diff 196194

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py

Show All 27 Lines def tearDown(self):
lldb.DBG.SetSelectedPlatform(self._initial_platform) lldb.DBG.SetSelectedPlatform(self._initial_platform)
super(MiniDumpUUIDTestCase, self).tearDown() super(MiniDumpUUIDTestCase, self).tearDown()
def verify_module(self, module, verify_path, verify_uuid): def verify_module(self, module, verify_path, verify_uuid):
uuid = module.GetUUIDString() uuid = module.GetUUIDString()
self.assertEqual(verify_path, module.GetFileSpec().fullpath) self.assertEqual(verify_path, module.GetFileSpec().fullpath)
self.assertEqual(verify_uuid, uuid) self.assertEqual(verify_uuid, uuid)
def get_minidump_modules(self, yaml_file):
minidump_path = self.getBuildArtifact(yaml_file + ".dmp")
self.yaml2obj(yaml_file, minidump_path)
self.target = self.dbg.CreateTarget(None)
self.process = self.target.LoadCore(minidump_path)
return self.target.modules
def test_zero_uuid_modules(self): def test_zero_uuid_modules(self):
""" """
Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid, Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid,
but contains a PDB70 value whose age is zero and whose UUID values are but contains a PDB70 value whose age is zero and whose UUID values are
all zero. Prior to a fix all such modules would be duplicated to the all zero. Prior to a fix all such modules would be duplicated to the
first one since the UUIDs claimed to be valid and all zeroes. Now we first one since the UUIDs claimed to be valid and all zeroes. Now we
ensure that the UUID is not valid for each module and that we have ensure that the UUID is not valid for each module and that we have
each of the modules in the target after loading the core each of the modules in the target after loading the core
""" """
self.dbg.CreateTarget(None) modules = self.get_minidump_modules("linux-arm-zero-uuids.yaml")
self.target = self.dbg.GetSelectedTarget()
self.process = self.target.LoadCore("linux-arm-zero-uuids.dmp")
modules = self.target.modules
self.assertEqual(2, len(modules)) self.assertEqual(2, len(modules))
self.verify_module(modules[0], "/file/does/not/exist/a", None) self.verify_module(modules[0], "/file/does/not/exist/a", None)
self.verify_module(modules[1], "/file/does/not/exist/b", None) self.verify_module(modules[1], "/file/does/not/exist/b", None)
def test_uuid_modules_no_age(self): def test_uuid_modules_no_age(self):
""" """
Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid, Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid,
and contains a PDB70 value whose age is zero and whose UUID values are and contains a PDB70 value whose age is zero and whose UUID values are
valid. Ensure we decode the UUID and don't include the age field in the UUID. valid. Ensure we decode the UUID and don't include the age field in the UUID.
""" """
self.dbg.CreateTarget(None) modules = self.get_minidump_modules("linux-arm-uuids-no-age.yaml")
self.target = self.dbg.GetSelectedTarget()
self.process = self.target.LoadCore("linux-arm-uuids-no-age.dmp")
modules = self.target.modules modules = self.target.modules
self.assertEqual(2, len(modules)) self.assertEqual(2, len(modules))
self.verify_module(modules[0], "/tmp/a", "01020304-0506-0708-090A-0B0C0D0E0F10") self.verify_module(modules[0], "/tmp/a", "01020304-0506-0708-090A-0B0C0D0E0F10")
self.verify_module(modules[1], "/tmp/b", "0A141E28-323C-4650-5A64-6E78828C96A0") self.verify_module(modules[1], "/tmp/b", "0A141E28-323C-4650-5A64-6E78828C96A0")
def test_uuid_modules_no_age_apple(self): def test_uuid_modules_no_age_apple(self):
""" """
Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid, Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid,
and contains a PDB70 value whose age is zero and whose UUID values are and contains a PDB70 value whose age is zero and whose UUID values are
valid. Ensure we decode the UUID and don't include the age field in the UUID. valid. Ensure we decode the UUID and don't include the age field in the UUID.
Also ensure that the first uint32_t is byte swapped, along with the next Also ensure that the first uint32_t is byte swapped, along with the next
two uint16_t values. Breakpad incorrectly byte swaps these values when it two uint16_t values. Breakpad incorrectly byte swaps these values when it
saves Darwin minidump files. saves Darwin minidump files.
""" """
self.dbg.CreateTarget(None) modules = self.get_minidump_modules("macos-arm-uuids-no-age.yaml")
self.target = self.dbg.GetSelectedTarget()
self.process = self.target.LoadCore("macos-arm-uuids-no-age.dmp")
modules = self.target.modules modules = self.target.modules
self.assertEqual(2, len(modules)) self.assertEqual(2, len(modules))
self.verify_module(modules[0], "/tmp/a", "04030201-0605-0807-090A-0B0C0D0E0F10") self.verify_module(modules[0], "/tmp/a", "04030201-0605-0807-090A-0B0C0D0E0F10")
self.verify_module(modules[1], "/tmp/b", "281E140A-3C32-5046-5A64-6E78828C96A0") self.verify_module(modules[1], "/tmp/b", "281E140A-3C32-5046-5A64-6E78828C96A0")
def test_uuid_modules_with_age(self): def test_uuid_modules_with_age(self):
""" """
Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid, Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid,
and contains a PDB70 value whose age is valid and whose UUID values are and contains a PDB70 value whose age is valid and whose UUID values are
valid. Ensure we decode the UUID and include the age field in the UUID. valid. Ensure we decode the UUID and include the age field in the UUID.
""" """
self.dbg.CreateTarget(None) modules = self.get_minidump_modules("linux-arm-uuids-with-age.yaml")
self.target = self.dbg.GetSelectedTarget()
self.process = self.target.LoadCore("linux-arm-uuids-with-age.dmp")
modules = self.target.modules
self.assertEqual(2, len(modules)) self.assertEqual(2, len(modules))
self.verify_module(modules[0], "/tmp/a", "01020304-0506-0708-090A-0B0C0D0E0F10-10101010") self.verify_module(modules[0], "/tmp/a", "01020304-0506-0708-090A-0B0C0D0E0F10-10101010")
self.verify_module(modules[1], "/tmp/b", "0A141E28-323C-4650-5A64-6E78828C96A0-20202020") self.verify_module(modules[1], "/tmp/b", "0A141E28-323C-4650-5A64-6E78828C96A0-20202020")
def test_uuid_modules_elf_build_id_16(self): def test_uuid_modules_elf_build_id_16(self):
""" """
Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid, Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid,
and contains a ELF build ID whose value is valid and is 16 bytes long. and contains a ELF build ID whose value is valid and is 16 bytes long.
""" """
self.dbg.CreateTarget(None) modules = self.get_minidump_modules("linux-arm-uuids-elf-build-id-16.yaml")
self.target = self.dbg.GetSelectedTarget()
self.process = self.target.LoadCore("linux-arm-uuids-elf-build-id-16.dmp")
modules = self.target.modules
self.assertEqual(2, len(modules)) self.assertEqual(2, len(modules))
self.verify_module(modules[0], "/tmp/a", "01020304-0506-0708-090A-0B0C0D0E0F10") self.verify_module(modules[0], "/tmp/a", "01020304-0506-0708-090A-0B0C0D0E0F10")
self.verify_module(modules[1], "/tmp/b", "0A141E28-323C-4650-5A64-6E78828C96A0") self.verify_module(modules[1], "/tmp/b", "0A141E28-323C-4650-5A64-6E78828C96A0")
def test_uuid_modules_elf_build_id_20(self): def test_uuid_modules_elf_build_id_20(self):
""" """
Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid, Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid,
and contains a ELF build ID whose value is valid and is 20 bytes long. and contains a ELF build ID whose value is valid and is 20 bytes long.
""" """
self.dbg.CreateTarget(None) modules = self.get_minidump_modules("linux-arm-uuids-elf-build-id-20.yaml")
self.target = self.dbg.GetSelectedTarget()
self.process = self.target.LoadCore("linux-arm-uuids-elf-build-id-20.dmp")
modules = self.target.modules
self.assertEqual(2, len(modules)) self.assertEqual(2, len(modules))
self.verify_module(modules[0], "/tmp/a", "01020304-0506-0708-090A-0B0C0D0E0F10-11121314") self.verify_module(modules[0], "/tmp/a", "01020304-0506-0708-090A-0B0C0D0E0F10-11121314")
self.verify_module(modules[1], "/tmp/b", "0A141E28-323C-4650-5A64-6E78828C96A0-AAB4BEC8") self.verify_module(modules[1], "/tmp/b", "0A141E28-323C-4650-5A64-6E78828C96A0-AAB4BEC8")
def test_uuid_modules_elf_build_id_zero(self): def test_uuid_modules_elf_build_id_zero(self):
""" """
Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid, Test multiple modules having a MINIDUMP_MODULE.CvRecord that is valid,
and contains a ELF build ID whose value is all zero. and contains a ELF build ID whose value is all zero.
""" """
self.dbg.CreateTarget(None) modules = self.get_minidump_modules("linux-arm-uuids-elf-build-id-zero.yaml")
self.target = self.dbg.GetSelectedTarget()
self.process = self.target.LoadCore("linux-arm-uuids-elf-build-id-zero.dmp")
modules = self.target.modules
self.assertEqual(2, len(modules)) self.assertEqual(2, len(modules))
self.verify_module(modules[0], "/not/exist/a", None) self.verify_module(modules[0], "/not/exist/a", None)
self.verify_module(modules[1], "/not/exist/b", None) self.verify_module(modules[1], "/not/exist/b", None)
@expectedFailureAll(oslist=["windows"]) @expectedFailureAll(oslist=["windows"])
def test_partial_uuid_match(self): def test_partial_uuid_match(self):
""" """
Breakpad has been known to create minidump files using CvRecord in each Breakpad has been known to create minidump files using CvRecord in each
module whose signature is set to PDB70 where the UUID only contains the module whose signature is set to PDB70 where the UUID only contains the
first 16 bytes of a 20 byte ELF build ID. Code was added to first 16 bytes of a 20 byte ELF build ID. Code was added to
ProcessMinidump.cpp to deal with this and allows partial UUID matching. ProcessMinidump.cpp to deal with this and allows partial UUID matching.
This test verifies that if we have a minidump with a 16 byte UUID, that This test verifies that if we have a minidump with a 16 byte UUID, that
we are able to associate a symbol file with a 20 byte UUID only if the we are able to associate a symbol file with a 20 byte UUID only if the
first 16 bytes match. In this case we will see the path from the file first 16 bytes match. In this case we will see the path from the file
we found in the test directory and the 20 byte UUID from the actual we found in the test directory and the 20 byte UUID from the actual
file, not the 16 byte shortened UUID from the minidump. file, not the 16 byte shortened UUID from the minidump.
""" """
so_path = self.getBuildArtifact("libuuidmatch.so") so_path = self.getBuildArtifact("libuuidmatch.so")
self.yaml2obj("libuuidmatch.yaml", so_path) self.yaml2obj("libuuidmatch.yaml", so_path)
self.dbg.CreateTarget(None)
self.target = self.dbg.GetSelectedTarget()
cmd = 'settings set target.exec-search-paths "%s"' % (os.path.dirname(so_path)) cmd = 'settings set target.exec-search-paths "%s"' % (os.path.dirname(so_path))
self.dbg.HandleCommand(cmd) self.dbg.HandleCommand(cmd)
self.process = self.target.LoadCore("linux-arm-partial-uuids-match.dmp") modules = self.get_minidump_modules("linux-arm-partial-uuids-match.yaml")
modules = self.target.modules
self.assertEqual(1, len(modules)) self.assertEqual(1, len(modules))
self.verify_module(modules[0], so_path, self.verify_module(modules[0], so_path,
"7295E17C-6668-9E05-CBB5-DEE5003865D5-5267C116") "7295E17C-6668-9E05-CBB5-DEE5003865D5-5267C116")
def test_partial_uuid_mismatch(self): def test_partial_uuid_mismatch(self):
""" """
Breakpad has been known to create minidump files using CvRecord in each Breakpad has been known to create minidump files using CvRecord in each
module whose signature is set to PDB70 where the UUID only contains the module whose signature is set to PDB70 where the UUID only contains the
first 16 bytes of a 20 byte ELF build ID. Code was added to first 16 bytes of a 20 byte ELF build ID. Code was added to
ProcessMinidump.cpp to deal with this and allows partial UUID matching. ProcessMinidump.cpp to deal with this and allows partial UUID matching.
This test verifies that if we have a minidump with a 16 byte UUID, that This test verifies that if we have a minidump with a 16 byte UUID, that
we are not able to associate a symbol file with a 20 byte UUID only if we are not able to associate a symbol file with a 20 byte UUID only if
any of the first 16 bytes do not match. In this case we will see the UUID any of the first 16 bytes do not match. In this case we will see the UUID
from the minidump file and the path from the minidump file. from the minidump file and the path from the minidump file.
""" """
so_path = self.getBuildArtifact("libuuidmismatch.so") so_path = self.getBuildArtifact("libuuidmismatch.so")
self.yaml2obj("libuuidmismatch.yaml", so_path) self.yaml2obj("libuuidmismatch.yaml", so_path)
self.dbg.CreateTarget(None)
self.target = self.dbg.GetSelectedTarget()
cmd = 'settings set target.exec-search-paths "%s"' % (os.path.dirname(so_path)) cmd = 'settings set target.exec-search-paths "%s"' % (os.path.dirname(so_path))
self.dbg.HandleCommand(cmd) self.dbg.HandleCommand(cmd)
self.process = self.target.LoadCore("linux-arm-partial-uuids-mismatch.dmp") modules = self.get_minidump_modules("linux-arm-partial-uuids-mismatch.yaml")
modules = self.target.modules
self.assertEqual(1, len(modules)) self.assertEqual(1, len(modules))
self.verify_module(modules[0], self.verify_module(modules[0],
"/invalid/path/on/current/system/libuuidmismatch.so", "/invalid/path/on/current/system/libuuidmismatch.so",
"7295E17C-6668-9E05-CBB5-DEE5003865D5") "7295E17C-6668-9E05-CBB5-DEE5003865D5")

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-partial-uuids-match.dmp

  • This is a binary file.

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-partial-uuids-match.yaml

--- !minidump
Streams:
- Type: SystemInfo
Processor Arch: ARM
Platform ID: Linux
CSD Version: '15E216'
CPU:
CPUID: 0x00000000
- Type: ModuleList
Modules:
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/invalid/path/on/current/system/libuuidmatch.so'
CodeView Record: 525344537295E17C66689E05CBB5DEE5003865D50000000000
...

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-partial-uuids-mismatch.dmp

  • This is a binary file.

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-partial-uuids-mismatch.yaml

--- !minidump
Streams:
- Type: SystemInfo
Processor Arch: ARM
Platform ID: Linux
CSD Version: '15E216'
CPU:
CPUID: 0x00000000
- Type: ModuleList
Modules:
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/invalid/path/on/current/system/libuuidmismatch.so'
CodeView Record: 525344537295E17C66689E05CBB5DEE5003865D50000000000
...

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-uuids-elf-build-id-16.dmp

  • This is a binary file.

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-uuids-elf-build-id-16.yaml

--- !minidump
Streams:
- Type: SystemInfo
Processor Arch: ARM
Platform ID: Linux
CSD Version: '15E216'
CPU:
CPUID: 0x00000000
- Type: ModuleList
Modules:
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/tmp/a'
CodeView Record: 4C4570420102030405060708090A0B0C0D0E0F10
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/tmp/b'
CodeView Record: 4C4570420A141E28323C46505A646E78828C96A0
...

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-uuids-elf-build-id-20.dmp

  • This is a binary file.

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-uuids-elf-build-id-20.yaml

--- !minidump
Streams:
- Type: SystemInfo
Processor Arch: ARM
Platform ID: Linux
CSD Version: '15E216'
CPU:
CPUID: 0x00000000
- Type: ModuleList
Modules:
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/tmp/a'
CodeView Record: 4C4570420102030405060708090A0B0C0D0E0F1011121314
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/tmp/b'
CodeView Record: 4C4570420A141E28323C46505A646E78828C96A0AAB4BEC8
...

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-uuids-elf-build-id-zero.dmp

  • This is a binary file.

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-uuids-elf-build-id-zero.yaml

--- !minidump
Streams:
- Type: SystemInfo
Processor Arch: ARM
Platform ID: Linux
CSD Version: '15E216'
CPU:
CPUID: 0x00000000
- Type: ModuleList
Modules:
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/not/exist/a'
CodeView Record: 4C45704200000000000000000000000000000000
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/not/exist/b'
CodeView Record: 4C45704200000000000000000000000000000000
...

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-uuids-no-age.dmp

  • This is a binary file.

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-uuids-no-age.yaml

--- !minidump
Streams:
- Type: SystemInfo
Processor Arch: ARM
Platform ID: Linux
CSD Version: '15E216'
CPU:
CPUID: 0x00000000
- Type: ModuleList
Modules:
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/tmp/a'
CodeView Record: 525344530102030405060708090A0B0C0D0E0F100000000000
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/tmp/b'
CodeView Record: 525344530A141E28323C46505A646E78828C96A00000000000
...

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-uuids-with-age.dmp

  • This is a binary file.

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-uuids-with-age.yaml

--- !minidump
Streams:
- Type: SystemInfo
Processor Arch: ARM
Platform ID: Linux
CSD Version: '15E216'
CPU:
CPUID: 0x00000000
- Type: ModuleList
Modules:
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/tmp/a'
CodeView Record: 525344530102030405060708090A0B0C0D0E0F101010101000
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/tmp/b'
CodeView Record: 525344530A141E28323C46505A646E78828C96A02020202000
...

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-zero-uuids.dmp

  • This is a binary file.

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-arm-zero-uuids.yaml

--- !minidump
Streams:
- Type: SystemInfo
Processor Arch: AMD64
Platform ID: Linux
CSD Version: '15E216'
labathAuthorUnsubmitted
Done
ReplyInline Actions

@clayborg: The OS in this minidump is inconsistent with the file name. Do you want me to rename the file, or change the OS in the minidump?

labath: @clayborg: The OS in this minidump is inconsistent with the file name. Do you want me to rename…
clayborgUnsubmitted
Not Done
ReplyInline Actions

Lets change the OS

clayborg: Lets change the OS
CPU:
Vendor ID: GenuineIntel
Version Info: 0x00000000
Feature Info: 0x00000000
- Type: ModuleList
Modules:
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/file/does/not/exist/a'
CodeView Record: '52534453000000000000000000000000000000000000000000'
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/file/does/not/exist/b'
CodeView Record: '52534453000000000000000000000000000000000000000000'
...

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/macos-arm-uuids-no-age.dmp

  • This is a binary file.

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/macos-arm-uuids-no-age.yaml

--- !minidump
Streams:
- Type: SystemInfo
Processor Arch: AMD64
Platform ID: MacOSX
CSD Version: '15E216'
CPU:
Vendor ID: GenuineIntel
Version Info: 0x00000000
Feature Info: 0x00000000
- Type: ModuleList
Modules:
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/tmp/a'
CodeView Record: 525344530102030405060708090A0B0C0D0E0F100000000000
- Base of Image: 0x0000000000001000
Size of Image: 0x00001000
Module Name: '/tmp/b'
CodeView Record: 525344530A141E28323C46505A646E78828C96A00000000000
...