Make changes to clang driver so it can pass -target-abi option to created jobs.
It needs a testcase and I don't see where Opts.ABI is used.
By the way, please don't set custom access policies. There's no need for them.
|82 ↗||(On Diff #15711)|
Not initialized in constructor.
Also, can you point me at the code that uses this variable? I can only see the code that sets it.
Not sure that the getTargetFeatures routine is a good place to configure the -target-abi option.
The getTargetFeatures routine called from the ClangAs::ConstructJob and from the Clang::ConstructJob. In the second case we add the -target-abi option twice. The first time when we call the getTargetFeatures and the second time when we call Clang::AddMIPSTargetArgs. I do not think it is a good idea.
And the patch still needs a test case.
|192 ↗||(On Diff #16140)|
At the line cc1as_main.cpp:82 you add new field ABI to the AssemblerInvocation structure. At the line cc1as_main.cpp:191 you initialize this filed by the -target-abi arguments. But where is this new field used? For example the AssemblerInvocation::CPU filed is initialized at the line 186 and passed to the createMCSubtargetInfo at the line 357.
You'll want to remove the -target-feature bits of this code... honestly it shouldn't even compile at this point.
Actually this patch to the testcase doesn't appear to be against top of tree - can you rebase against that?