Page MenuHomePhabricator

[clang-tidy] Add test support for the fix description.
AbandonedPublic

Authored by hokein on Apr 16 2019, 7:53 AM.

Details

Reviewers
alexfh
Summary

Add a new annotation "CHECK-FIX-DESCRIPTIONS" to lit test to
verify the fix description provided by checks.

Event Timeline

hokein created this revision.Apr 16 2019, 7:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2019, 7:53 AM
Herald added a subscriber: xazax.hun. · View Herald Transcript
alexfh requested changes to this revision.Apr 16 2019, 1:01 PM
alexfh added inline comments.
clang-tools-extra/test/clang-tidy/check_clang_tidy.py
109

Wait, how do "check descriptions" differ from notes?

This revision now requires changes to proceed.Apr 16 2019, 1:01 PM
hokein updated this revision to Diff 201221.May 24 2019, 6:20 AM

Use CHECK-NOTES.

Based on our last offline discussion, it is possible to use CHECK-NOTES to verify fix descriptions. However, CHECK-NOTES enforce sto verify all note diagnostic messages, some existing tests will be failed because they don't cover all notes (the number is not large, only ~60), I'll update the tests when updating the relative checks.

Finally (after every check provides fix descriptions), we may deprecate CHECK-MESSAGES, and in favor of CHECK-NOTES.

hokein abandoned this revision.Jun 6 2019, 8:07 AM