Page MenuHomePhabricator

Remove some more unused headers from MachineFunction.h and friends.
ClosedPublic

Authored by echristo on Apr 15 2019, 5:18 PM.

Details

Summary

Versus some of the earlier attempts here this is a little more difficult since most of these headers are still getting here transitively - but some grepping in the file convinced me that none of the things I think are here are here.

Diff Detail

Repository
rL LLVM

Event Timeline

echristo created this revision.Apr 15 2019, 5:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2019, 5:18 PM
dblaikie accepted this revision.Apr 15 2019, 5:23 PM

Sounds good to me.
How'd you test that the MachineMemOperand.h changes were OK? Looks like it doesn't have an implementation file, so I'm not sure it's included first in any file - which means it's harder to tell if removing headers from it is valid/keeps it standalone (since its inclusion context might be allowing it to get away without including necessary headers)

This revision is now accepted and ready to land.Apr 15 2019, 5:23 PM

Sounds good to me.
How'd you test that the MachineMemOperand.h changes were OK? Looks like it doesn't have an implementation file, so I'm not sure it's included first in any file - which means it's harder to tell if removing headers from it is valid/keeps it standalone (since its inclusion context might be allowing it to get away without including necessary headers)

Basically grepping for Metadata and Inst things in the file itself. It's pretty short and I just read it. Always a possibility I missed something that's being gotten via transitive include though.

This revision was automatically updated to reflect the committed changes.