Page MenuHomePhabricator

[Support] Add a test for recursive response file expansion
ClosedPublic

Authored by smeenai on Fri, Apr 12, 12:54 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

smeenai created this revision.Fri, Apr 12, 12:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Apr 12, 12:54 PM
hans accepted this revision.Mon, Apr 15, 1:45 AM

Looks good to me.

llvm/unittests/Support/CommandLineTest.cpp
730 ↗(On Diff #194942)

Not that it matters, but would using .str() instead of .c_str() work (relying on StringRef's conversion operator to std::sttring)?

732 ↗(On Diff #194942)

ditto

This revision is now accepted and ready to land.Mon, Apr 15, 1:45 AM
smeenai marked 2 inline comments as done.Mon, Apr 15, 2:20 PM
smeenai added inline comments.
llvm/unittests/Support/CommandLineTest.cpp
730 ↗(On Diff #194942)

That doesn't work, cos it tries to create a Twine. I could do .str().str(), but I don't think that's cleaner.

732 ↗(On Diff #194942)

Sure.

smeenai updated this revision to Diff 195245.Mon, Apr 15, 2:21 PM

Review comments

This revision was automatically updated to reflect the committed changes.