Page MenuHomePhabricator

[clang][ASTContext] Try to exit early before loading serialize comments from AST files
ClosedPublic

Authored by jkorous on Apr 9 2019, 6:34 PM.

Details

Summary

Loading external comments is expensive. This change probably doesn't apply to common cases but is for free and would save some work in case none of the declaration needs external comments to be loaded.

Diff Detail

Repository
rL LLVM

Event Timeline

jkorous created this revision.Apr 9 2019, 6:34 PM
gribozavr accepted this revision.Apr 10 2019, 3:08 AM
This revision is now accepted and ready to land.Apr 10 2019, 3:08 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2019, 1:23 PM