Page MenuHomePhabricator

Revert LIS handling in MachineDCE
ClosedPublic

Authored by rampitec on Apr 9 2019, 8:50 AM.

Details

Summary

One of out of tree targets has regressed with this patch. Reverting
it for now and let liveness to be fully reconstructed in case pass
was used after the LIS is created to resolve the regression.

Diff Detail

Repository
rL LLVM

Event Timeline

rampitec created this revision.Apr 9 2019, 8:50 AM

FYI, changes in AMDGPU tests are just because of the liveness rebuild which results in a slightly different and non important allocation change.

bjope accepted this revision.Apr 9 2019, 9:02 AM

Thanks, LGTM!

nit: Maybe you want to add the reproducer for the "multiple connected intervals" for future reference?

This revision is now accepted and ready to land.Apr 9 2019, 9:02 AM
rampitec updated this revision to Diff 194349.Apr 9 2019, 9:09 AM

Added regression test.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 9 2019, 9:13 AM