This is an archive of the discontinued LLVM Phabricator instance.

Add missing space between \btrue
ClosedPublic

Authored by kkleine on Apr 9 2019, 12:47 AM.

Details

Summary

There was a space missing in some the documentation for lldb::BreakpointsWriteToFile.

This fixes the following doxygen warning when building the lldb-cpp-doc target:

llvm-project/lldb/include/lldb/API/SBTarget.h:775 warning: Found unknown command `\btrue'

Diff Detail

Repository
rLLDB LLDB

Event Timeline

kkleine created this revision.Apr 9 2019, 12:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 9 2019, 12:47 AM
kkleine updated this revision to Diff 194259.Apr 9 2019, 12:52 AM

Updated summary to reflect what doxygen error was addressed.

kkleine edited the summary of this revision. (Show Details)Apr 9 2019, 12:53 AM
kkleine edited the summary of this revision. (Show Details)
kkleine edited the summary of this revision. (Show Details)Apr 9 2019, 12:54 AM
JDevlieghere accepted this revision.Apr 9 2019, 1:11 AM
JDevlieghere added a subscriber: JDevlieghere.

Thanks!

This revision is now accepted and ready to land.Apr 9 2019, 1:11 AM

Please let me know if you don't have commit access (yet) and need someone to commit this for you.

Please let me know if you don't have commit access (yet) and need someone to commit this for you.

I think I don't have commit access (yet) and would like if someone can commit this for me. It was my first commit to the LLDB project and I wanted to get familiar with phabricator and the arc tool. Is phabricator here to stay or are there plans to move to github or something else? I'm just a bit confused still about some SVN revisions showing up here and there and why that is. I guess it will clear up in some time.

kkleine updated this revision to Diff 194263.Apr 9 2019, 1:32 AM
  • Fix doxygen warning about function argument
This revision was automatically updated to reflect the committed changes.
kkleine retitled this revision from Add missing space between \btrue to Fix doxygen warnings for lldb-cpp-doc target.Apr 9 2019, 1:34 AM
kkleine edited the summary of this revision. (Show Details)

I think I don't have commit access (yet) and would like if someone can commit this for me. It was my first commit to the LLDB project and I wanted to get familiar with phabricator and the arc tool. Is phabricator here to stay or are there plans to move to github or something else? I'm just a bit confused still about some SVN revisions showing up here and there and why that is. I guess it will clear up in some time.

Currently, we're still using svn, but the goal is to move to a git by the next US developer meeting (October 2019). Although the code would be hosted Github, there are no immediate plans to move away from Phabricator for code reviews. It's already configured to track the monorepo mirror on Github (https://reviews.llvm.org/source/llvm-github/repository/master/).

TL;DR: Phabricator tracks code hosted externally. Currently it's still on svn, but it'll be hosted on Github later this year.

kkleine retitled this revision from Fix doxygen warnings for lldb-cpp-doc target to Add missing space between \btrue.Apr 9 2019, 1:38 AM
kkleine edited the summary of this revision. (Show Details)
kkleine edited the summary of this revision. (Show Details)