Page MenuHomePhabricator

[LLVM-C] Add Section and Symbol Iterator Accessors for Object File Binaries
ClosedPublic

Authored by CodaFi on Apr 8 2019, 7:01 AM.

Details

Summary

This brings us to full feature parity with the old API, so I've deprecated it and updated the tests. I'll do a follow-up patch to do some more cleanup and documentation work in this header.

Diff Detail

Repository
rL LLVM

Event Timeline

CodaFi created this revision.Apr 8 2019, 7:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 8 2019, 7:01 AM
This revision is now accepted and ready to land.Apr 8 2019, 7:44 AM
CodaFi updated this revision to Diff 194381.Apr 9 2019, 12:58 PM

Correct a typo in the header

CodaFi updated this revision to Diff 194394.Apr 9 2019, 2:07 PM

The ELF section and symbol iterators can produce error values which turn into NULL underlying data in the iterators. Propagate this out as a NULL returned iterator.

CodaFi added a comment.Apr 9 2019, 2:40 PM

@whitequark Could you give it one more look. Had to fix a corner-case.

Yup, good catch! I'll make sure to check for this in the future as well.

This revision was automatically updated to reflect the committed changes.