This is an archive of the discontinued LLVM Phabricator instance.

NFC: Move API uses of MD5::MD5Result to Optional
ClosedPublic

Authored by echristo on Apr 4 2019, 4:13 PM.

Details

Summary

The other half of most of this API is Optional and it's literally... optional, so let's make it so.

Diff Detail

Repository
rL LLVM

Event Timeline

echristo created this revision.Apr 4 2019, 4:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 4 2019, 4:13 PM
dblaikie accepted this revision.Apr 4 2019, 4:21 PM

Looks good to me (:

llvm/lib/MC/MCDwarf.cpp
364 ↗(On Diff #193802)

You can write this as "*DwarfFile.Checksum" rather than "DwarfFile.Checksum.getValue()" if you like. (I tend to prefer that)

This revision is now accepted and ready to land.Apr 4 2019, 4:21 PM
echristo marked 2 inline comments as done.Apr 4 2019, 4:34 PM
echristo added inline comments.
llvm/lib/MC/MCDwarf.cpp
364 ↗(On Diff #193802)

SGTM. :)

This revision was automatically updated to reflect the committed changes.
echristo marked an inline comment as done.