Add dropped ManualDWARFIndex assert()

[jankratochvil]

Summary

D47253 dropped this assertion. So either add it back by this patch or otherwise I will remove currently unused SymbolFileDWARF::GetBaseCompileUnit.

[labath]

I don't exactly remember my thought processes there, but I guess I have dropped that assert during the refactor because it was obvious to me.

Now that you mention it, I don't have any particular opinion on what we should do. If it makes your job any easier, then go ahead and remove GetBaseCompileUnit. Otherwise, I suppose it might be good to re-add the assert.

[jankratochvil]

Maybe I will have to update GetBaseCompileUnit, maybe not. But as I find the assert useful (for -fdebug-types-section -gsplit-dwarf) going to add back the assertion. Thanks for the reply.

source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp

TaskPool::RunTasks([&]() { finalize_fn(&IndexSet::function_basenames); },
                      [&]() { finalize_fn(&IndexSet::function_selectors); },
                      [&]() { finalize_fn(&IndexSet::objc_class_selectors); },
                      [&]() { finalize_fn(&IndexSet::globals); },
                      [&]() { finalize_fn(&IndexSet::types); },
                      [&]() { finalize_fn(&IndexSet::namespaces); });
 }
 
 void ManualDWARFIndex::IndexUnit(DWARFUnit &unit, IndexSet &set) {
+  assert(!unit.GetSymbolFileDWARF()->GetBaseCompileUnit() &&
+      "DWARFUnit associated with .dwo or .dwp should not be indexed directly");
+
   Log *log = LogChannelDWARF::GetLogIfAll(DWARF_LOG_LOOKUPS);
 
   if (log) {
     m_module.LogMessage(
         log, "ManualDWARFIndex::IndexUnit for compile unit at .debug_info[0x%8.8x]",
         unit.GetOffset());
   }