This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] There is no such thing as CMAKE_C_CFLAGS, it's CMAKE_C_FLAGS
ClosedPublic

Authored by lebedev.ri on Apr 3 2019, 10:09 AM.

Download Raw Diff

Details

Reviewers

homerdin
MatzeB
hfinkel
fhahn

Commits

rOLDT358084: [test-suite] There is no such thing as CMAKE_C_CFLAGS, it's CMAKE_C_FLAGS
rL358084: [test-suite] There is no such thing as CMAKE_C_CFLAGS, it's CMAKE_C_FLAGS

Summary

Noticed by accident.

Diff Detail

Repository: rL LLVM

Event Timeline

lebedev.ri created this revision.Apr 3 2019, 10:09 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2019, 10:09 AM

Herald added a subscriber: mgorny. · View Herald Transcript

lebedev.ri added a reviewer: hfinkel.Apr 5 2019, 1:02 PM

Looks like a straight forward fix, LGTM as there is no CMAKE_C_CFLAGS variable.

This revision is now accepted and ready to land.Apr 10 2019, 5:07 AM

Thank you for the review.
Pleas note a few other test-suite patches, maybe something else looks straight forward :)

Closed by commit rL358084: [test-suite] There is no such thing as CMAKE_C_CFLAGS, it's CMAKE_C_FLAGS (authored by lebedevri). · Explain WhyApr 10 2019, 7:10 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

test-suite/

trunk/

CMakeLists.txt

2 lines

Diff 194508

test-suite/trunk/CMakeLists.txt

	Show First 20 Lines • Show All 144 Lines • ▼ Show 20 Lines
	# want to apply flags that get not override even when the user manually			# want to apply flags that get not override even when the user manually
	# specifies CMAKE_C_FLAGS and similar.			# specifies CMAKE_C_FLAGS and similar.
	set(TEST_SUITE_EXTRA_C_FLAGS CACHE STRING "Extra flags for CMAKE_C_FLAGS")			set(TEST_SUITE_EXTRA_C_FLAGS CACHE STRING "Extra flags for CMAKE_C_FLAGS")
	set(TEST_SUITE_EXTRA_CXX_FLAGS CACHE STRING "Extra flags for CMAKE_CXX_FLAGS")			set(TEST_SUITE_EXTRA_CXX_FLAGS CACHE STRING "Extra flags for CMAKE_CXX_FLAGS")
	set(TEST_SUITE_EXTRA_EXE_LINKER_FLAGS CACHE STRING			set(TEST_SUITE_EXTRA_EXE_LINKER_FLAGS CACHE STRING
	"Extra flags for CMAKE_EXE_LINKER_FLAGS")			"Extra flags for CMAKE_EXE_LINKER_FLAGS")
	mark_as_advanced(TEST_SUITE_EXTRA_C_FLAGS, TEST_SUITE_EXTRA_CXX_FLAGS,			mark_as_advanced(TEST_SUITE_EXTRA_C_FLAGS, TEST_SUITE_EXTRA_CXX_FLAGS,
	TEST_SUITE_EXTRA_EXE_LINKER_FLAGS)			TEST_SUITE_EXTRA_EXE_LINKER_FLAGS)
	set(CMAKE_C_CFLAGS "${CMAKE_C_CFLAGS} ${TEST_SUITE_EXTRA_C_FLAGS}")			set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${TEST_SUITE_EXTRA_C_FLAGS}")
	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${TEST_SUITE_EXTRA_CXX_FLAGS}")			set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${TEST_SUITE_EXTRA_CXX_FLAGS}")
	set(CMAKE_EXE_LINKER_FLAGS			set(CMAKE_EXE_LINKER_FLAGS
	"${CMAKE_EXE_LINKER_FLAGS} ${TEST_SUITE_EXTRA_EXE_LINKER_FLAGS}")			"${CMAKE_EXE_LINKER_FLAGS} ${TEST_SUITE_EXTRA_EXE_LINKER_FLAGS}")

	# This is either directly the C++ ABI library or the full C++ library			# This is either directly the C++ ABI library or the full C++ library
	# which pulls in the ABI transitively.			# which pulls in the ABI transitively.
	set(TEST_SUITE_CXX_ABI "default" CACHE STRING "Specify C++ ABI library to use.")			set(TEST_SUITE_CXX_ABI "default" CACHE STRING "Specify C++ ABI library to use.")
	set(CXXABIS "none default libstdc++ libsupc++ libc++ libc++abi")			set(CXXABIS "none default libstdc++ libsupc++ libc++ libc++abi")
	▲ Show 20 Lines • Show All 158 Lines • Show Last 20 Lines