[RISCV] Implement adding a displacement to a BlockAddress
ClosedPublic
Actions

Authored by rogfer01 on Apr 2 2019, 9:03 AM.

Details

Reviewers

asb
lewis-revill
jrtc27

Commits

rGe011e4f89cce: [RISCV] Implement adding a displacement to a BlockAddress
rL357752: [RISCV] Implement adding a displacement to a BlockAddress

Summary

Recent change rL357393 uses MachineInstrBuilder::addDisp to add a based on a BlockAddress but this case was not implemented.

This patch adds the missing case and a test for RISC-V that exercises the new case.

Diff Detail

Repository: rL LLVM

Event Timeline

rogfer01 created this revision.Apr 2 2019, 9:03 AM

Herald added a project: Restricted Project. · View Herald TranscriptApr 2 2019, 9:03 AM

Herald added subscribers: llvm-commits, benna, psnobl and 16 others. · View Herald Transcript

Thanks, I didn't realise this was the case.

test/CodeGen/RISCV/codemodel-lowering.ll
126 ↗	(On Diff #193308)	Is this phi node necessary for the test?

ChangeLog

Remove dead phi in the test

rogfer01 marked an inline comment as done.Apr 3 2019, 8:25 AM

Thanks Roger, this looks good to me.

This revision is now accepted and ready to land.Apr 4 2019, 6:15 AM

Lewis, Alex: thanks for the review.

I will commit it shortly.

Closed by commit rL357752: [RISCV] Implement adding a displacement to a BlockAddress (authored by rogfer01). · Explain WhyApr 5 2019, 1:39 AM

This revision was automatically updated to reflect the committed changes.

jrtc27 mentioned this in D92097: [RISCV] Basic jump table lowering.Nov 26 2020, 7:19 AM

Revision Contents
Changeset List

Path

Size

llvm/

trunk/

include/

llvm/

CodeGen/

MachineInstrBuilder.h

3 lines

test/

CodeGen/

RISCV/

codemodel-lowering.ll

84 lines

Diff 193846

View Options

llvm/trunk/include/llvm/CodeGen/MachineInstrBuilder.h