Page MenuHomePhabricator

Fix CPPBackend CodeGen
ClosedPublic

Authored by chenwj on Oct 27 2014, 8:27 PM.

Details

Summary

Fix CPPBackend CodeGen so that its output can be compiled with the current trunk.

Diff Detail

Event Timeline

chenwj updated this revision to Diff 15515.Oct 27 2014, 8:27 PM
chenwj retitled this revision from to Fix CPPBackend CodeGen.
chenwj updated this object.
chenwj edited the test plan for this revision. (Show Details)
chenwj added a reviewer: chapuni.
chenwj added a subscriber: Unknown Object (MLST).

I think this looks fine, having chased down the default arguments. But just to make sure: we both think the verifier will default to dbgs() for its output after this change (mainly rather than /dev/null)?

If so, go for it (and thanks for working on the update).

Tim.

t.p.northover accepted this revision.Oct 27 2014, 8:48 PM
t.p.northover added a reviewer: t.p.northover.
This revision is now accepted and ready to land.Oct 27 2014, 8:48 PM

I think this looks fine, having chased down the default arguments. But just to make sure: we both think the verifier will default to dbgs() for its output after this change (mainly rather than /dev/null)?

If so, go for it (and thanks for working on the update).

Tim.

Thanks, Tim.

Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Looks like patch was not committed, but as build fix it most likely obsolete.