Page MenuHomePhabricator

[LLD][COFF] Move type merging structures out of PDB.cpp. NFC
ClosedPublic

Authored by aganea on Apr 1 2019, 9:09 AM.

Details

Summary

Introduce a new TypeMerger class, out of some type-merge-specific structures from PDB.cpp

No changes intended / this is only moving code around.

This patch is step 3. in "Proposed commit strategy" in D59226

Diff Detail

Event Timeline

aganea created this revision.Apr 1 2019, 9:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2019, 9:09 AM
aganea updated this revision to Diff 193105.Apr 1 2019, 9:11 AM
aganea edited the summary of this revision. (Show Details)
aganea edited the summary of this revision. (Show Details)Apr 1 2019, 12:40 PM
rnk accepted this revision.Apr 1 2019, 4:58 PM

lgtm

COFF/TypeMerger.h
20 ↗(On Diff #193105)

This thing actually has methods, and maybe one day it will have private members, so let's make it a class:
https://llvm.org/docs/CodingStandards.html#use-of-class-and-struct-keywords

This revision is now accepted and ready to land.Apr 1 2019, 4:58 PM
This revision was automatically updated to reflect the committed changes.