This is an archive of the discontinued LLVM Phabricator instance.

Differential D60060

[X86] Fix a test from r357317
ClosedPublic

Authored by krasimir on Apr 1 2019, 4:38 AM.

Details

Reviewers
bkramer
Commits
rG7af32444b9b1: [X86] Fix a test from r357317
rL357380: [X86] Fix a test from r357317
Summary

The missing < causes the lld command to override the test file, which fails in
environments marking the test files as readonly.

Diff Detail

Event Timeline

krasimir created this revision.Apr 1 2019, 4:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2019, 4:38 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
krasimir added a reviewer: bkramer.Apr 1 2019, 4:38 AM
Harbormaster completed remote builds in B29893: Diff 193064.Apr 1 2019, 4:39 AM
bkramer accepted this revision.Apr 1 2019, 4:39 AM

lg

This revision is now accepted and ready to land.Apr 1 2019, 4:39 AM
Closed by commit rL357380: [X86] Fix a test from r357317 (authored by krasimir). · Explain WhyApr 1 2019, 4:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
CodeGen/
X86/
2 lines

Diff 193064

test/CodeGen/X86/win64-nosse-error.ll

; RUN: not --crash llc %s -mattr="-sse" 2>&1 | FileCheck %s ; RUN: not --crash llc < %s -mattr="-sse" 2>&1 | FileCheck %s
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-pc-windows-macho" target triple = "x86_64-pc-windows-macho"
; Function Attrs: noimplicitfloat noinline noredzone nounwind optnone ; Function Attrs: noimplicitfloat noinline noredzone nounwind optnone
define void @crash() #0 { define void @crash() #0 {
call void (i32*, ...) @func(i32* null, double undef) call void (i32*, ...) @func(i32* null, double undef)
ret void ret void
} }
; CHECK: in function crash void (): Win64 ABI varargs functions require SSE to be enabled ; CHECK: in function crash void (): Win64 ABI varargs functions require SSE to be enabled
; Function Attrs: noimplicitfloat noredzone ; Function Attrs: noimplicitfloat noredzone
declare void @func(i32*, ...) declare void @func(i32*, ...)
attributes #0 = { "target-cpu"="x86-64" "target-features"="-sse"} attributes #0 = { "target-cpu"="x86-64" "target-features"="-sse"}