gn build: Add build files for most clang-tools-extra unit tests

[mbonadei]

LGTM, just a small style comment.

llvm/utils/gn/secondary/clang-tools-extra/unittests/clang-apply-replacements/BUILD.gn

3 ↗

(On Diff #192995)

Why don't we use output_name here as well? It seems to be available for executables (https://gn.googlesource.com/gn/+/master/docs/reference.md#target-declarations-executable_declare-an-executable-target-variables). The current style seems to be lisp-case for target names and have output_name matching the cmake build.

[thakis]

Thanks!

llvm/utils/gn/secondary/clang-tools-extra/unittests/clang-apply-replacements/BUILD.gn

3 ↗

(On Diff #192995)

That's a good question. phosek asked about this too here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20181231/614211.html

I don't think there's a really good reason for this. I don't remember why I did it this way.

Trying to come up with a justification after the fact: A weak reason is that for static libraries it doesn't really matter what they're called on disk (other than to llvm-config's lit tests, which is why the GN build matches the cmake build -- else I wouldn't set the output name there), but for executables you need to know the name of the executable to run it, and it's maybe nice if the target has the same name as the executable for that reason.

clang-tools-extra/trunk/unittests/clang-tidy/CMakeLists.txt

add_extra_unittest(ClangTidyTests
   ClangTidyOptionsTest.cpp
   IncludeInserterTest.cpp
   GoogleModuleTest.cpp
   LLVMModuleTest.cpp
   NamespaceAliaserTest.cpp
   ObjCModuleTest.cpp
   OverlappingReplacementsTest.cpp
   UsingInserterTest.cpp
-  ReadabilityModuleTest.cpp)
+  ReadabilityModuleTest.cpp
+  )
 
 target_link_libraries(ClangTidyTests
   PRIVATE
   clangAST
   clangASTMatchers
   clangBasic
   clangFrontend
   clangLex

llvm/trunk/utils/gn/build/sync_source_lists_from_cmake.py

for gn_file in gn_files:
             print('remove:\n' + '\n'.join(remove))
         print()
 
 
 def sync_unittests():
     # Matches e.g. |add_llvm_unittest_with_input_files|.
     unittest_re = re.compile(r'^add_\S+_unittest', re.MULTILINE)
 
+    # FIXME: Add 'clang-tools-extra'.
     checked = [ 'clang', 'lld', 'llvm' ]
     for c in checked:
         for root, _, _ in os.walk(os.path.join(c, 'unittests')):
             cmake_file = os.path.join(root, 'CMakeLists.txt')
             if not os.path.exists(cmake_file):
                 continue
             if not unittest_re.search(open(cmake_file).read()):
                 continue  # Skip CMake files that just add subdirectories.

llvm/trunk/utils/gn/secondary/clang-tools-extra/clangd/indexer/BUILD.gn

 executable("clangd-indexer") {
   configs += [ "//llvm/utils/gn/build:clang_code" ]
   deps = [
     "//clang-tools-extra/clangd",
     "//clang/lib/AST",
     "//clang/lib/Basic",
     "//clang/lib/Frontend",
     "//clang/lib/Index",
     "//clang/lib/Lex",
     "//clang/lib/Tooling",
     "//llvm/lib/Support",
   ]
-  include_dirs = [ "..", ]
+  include_dirs = [ ".." ]
   sources = [
     "IndexerMain.cpp",
   ]
 }

llvm/trunk/utils/gn/secondary/clang-tools-extra/test/BUILD.gn

deps = [
     "//clang-tools-extra/clang-move/tool:clang-move",
     "//clang-tools-extra/clang-query/tool:clang-query",
     "//clang-tools-extra/clang-reorder-fields/tool:clang-reorder-fields",
     "//clang-tools-extra/clang-tidy/tool:clang-tidy",
     "//clang-tools-extra/clangd/indexer:clangd-indexer",
     "//clang-tools-extra/clangd/tool:clangd",
     "//clang-tools-extra/modularize",
     "//clang-tools-extra/pp-trace",
+    "//clang-tools-extra/unittests",
     "//clang/lib/Headers",
     "//clang/tools/c-index-test",
     "//clang/tools/clang-rename",
     "//clang/tools/driver:symlinks",
     "//llvm/tools/llvm-bcanalyzer",
     "//llvm/utils/FileCheck",
     "//llvm/utils/count",
     "//llvm/utils/llvm-lit",
     "//llvm/utils/not",
   ]
 
-  # FIXME: dep on "//clang-tools-extra/unittests" once it exists
   # FIXME: dep on dexp once it exist
   testonly = true
 }
 
 action("check-clang-tools") {
   script = "$root_out_dir/bin/llvm-lit"
   if (host_os == "win") {
     script += ".py"

llvm/trunk/utils/gn/secondary/clang-tools-extra/unittests/BUILD.gn

+group("unittests") {
+  deps = [
+    "clang-apply-replacements:ClangApplyReplacementsTests",
+    "clang-change-namespace:ClangChangeNamespaceTests",
+    "clang-doc:ClangDocTests",
+    "clang-include-fixer:ClangIncludeFixerTests",
+    "clang-include-fixer/find-all-symbols:FindAllSymbolsTests",
+    "clang-move:ClangMoveTests",
+    "clang-query:ClangQueryTests",
+    "clang-tidy:ClangTidyTests",
+    "clangd:ClangdTests",
+  ]
+  # FIXME: dep on clangd/xpc:ClangdXpcTests once it exists
+  testonly = true
+}

llvm/trunk/utils/gn/secondary/clang-tools-extra/unittests/clang-apply-replacements/BUILD.gn

+import("//llvm/utils/unittest/unittest.gni")
+
+unittest("ClangApplyReplacementsTests") {
+  configs += [ "//llvm/utils/gn/build:clang_code" ]
+  deps = [
+    "//clang-tools-extra/clang-apply-replacements",
+    "//clang/lib/Basic",
+    "//clang/lib/Tooling/Core",
+    "//clang/lib/Tooling/Refactoring",
+  ]
+  include_dirs = [ "//clang-tools-extra/clang-apply-replacements/include" ]
+  sources = [
+    "ApplyReplacementsTest.cpp",
+  ]
+}

llvm/trunk/utils/gn/secondary/clang-tools-extra/unittests/clang-change-namespace/BUILD.gn

+import("//llvm/utils/unittest/unittest.gni")
+
+unittest("ClangChangeNamespaceTests") {
+  configs += [ "//llvm/utils/gn/build:clang_code" ]
+  deps = [
+    "//clang-tools-extra/clang-change-namespace",
+    "//clang/lib/AST",
+    "//clang/lib/ASTMatchers",
+    "//clang/lib/Basic",
+    "//clang/lib/Format",
+    "//clang/lib/Frontend",
+    "//clang/lib/Rewrite",
+    "//clang/lib/Serialization",
+    "//clang/lib/Tooling",
+    "//clang/lib/Tooling/Core",
+    "//llvm/lib/Support",
+  ]
+  include_dirs = [
+    "//clang-tools-extra/clang-change-namespace",
+
+    # We'd like clang/unittests/Tooling/RewriterTestContext.h in the test.
+    "//clang",
+  ]
+  sources = [
+    "ChangeNamespaceTests.cpp",
+  ]
+}

llvm/trunk/utils/gn/secondary/clang-tools-extra/unittests/clang-doc/BUILD.gn

+import("//llvm/utils/unittest/unittest.gni")
+
+unittest("ClangDocTests") {
+  configs += [ "//llvm/utils/gn/build:clang_code" ]
+  deps = [
+    "//clang-tools-extra/clang-doc",
+    "//clang/lib/AST",
+    "//clang/lib/ASTMatchers",
+    "//clang/lib/Basic",
+    "//clang/lib/Format",
+    "//clang/lib/Frontend",
+    "//clang/lib/Rewrite",
+    "//clang/lib/Serialization",
+    "//clang/lib/Tooling",
+    "//clang/lib/Tooling/Core",
+    "//llvm/lib/Bitcode/Reader",
+    "//llvm/lib/Bitcode/Writer",
+    "//llvm/lib/Support",
+  ]
+  include_dirs = [ "//clang-tools-extra/clang-doc" ]
+  sources = [
+    "BitcodeTest.cpp",
+    "ClangDocTest.cpp",
+    "MDGeneratorTest.cpp",
+    "MergeTest.cpp",
+    "SerializeTest.cpp",
+    "YAMLGeneratorTest.cpp",
+  ]
+}

llvm/trunk/utils/gn/secondary/clang-tools-extra/unittests/clang-include-fixer/BUILD.gn

+import("//llvm/utils/unittest/unittest.gni")
+
+unittest("ClangIncludeFixerTests") {
+  configs += [ "//llvm/utils/gn/build:clang_code" ]
+  deps = [
+    "//clang-tools-extra/clang-include-fixer",
+    "//clang-tools-extra/clang-include-fixer/find-all-symbols",
+    "//clang/lib/Basic",
+    "//clang/lib/Format",
+    "//clang/lib/Frontend",
+    "//clang/lib/Rewrite",
+    "//clang/lib/Serialization",
+    "//clang/lib/Tooling",
+    "//clang/lib/Tooling/Core",
+    "//llvm/lib/Support",
+  ]
+  include_dirs = [
+    "//clang-tools-extra/clang-include-fixer",
+
+    # We'd like clang/unittests/Tooling/RewriterTestContext.h in the test.
+    "//clang",
+  ]
+  sources = [
+    "FuzzySymbolIndexTests.cpp",
+    "IncludeFixerTest.cpp",
+  ]
+}

llvm/trunk/utils/gn/secondary/clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/BUILD.gn

+import("//llvm/utils/unittest/unittest.gni")
+
+unittest("FindAllSymbolsTests") {
+  configs += [ "//llvm/utils/gn/build:clang_code" ]
+  deps = [
+    "//clang-tools-extra/clang-include-fixer/find-all-symbols",
+    "//clang/lib/AST",
+    "//clang/lib/ASTMatchers",
+    "//clang/lib/Basic",
+    "//clang/lib/Frontend",
+    "//clang/lib/Lex",
+    "//clang/lib/Serialization",
+    "//clang/lib/Tooling",
+    "//llvm/lib/Support",
+  ]
+  include_dirs = [ "//clang-tools-extra/clang-include-fixer/find-all-symbols" ]
+  sources = [
+    "FindAllSymbolsTests.cpp",
+  ]
+}

llvm/trunk/utils/gn/secondary/clang-tools-extra/unittests/clang-move/BUILD.gn

+import("//llvm/utils/unittest/unittest.gni")
+
+unittest("ClangMoveTests") {
+  configs += [ "//llvm/utils/gn/build:clang_code" ]
+  deps = [
+    "//clang-tools-extra/clang-move",
+    "//clang/lib/AST",
+    "//clang/lib/ASTMatchers",
+    "//clang/lib/Basic",
+    "//clang/lib/Format",
+    "//clang/lib/Frontend",
+    "//clang/lib/Rewrite",
+    "//clang/lib/Serialization",
+    "//clang/lib/Tooling",
+    "//clang/lib/Tooling/Core",
+    "//llvm/lib/Support",
+  ]
+  include_dirs = [
+    "//clang-tools-extra/clang-move",
+
+    # We'd like clang/unittests/Tooling/RewriterTestContext.h in the test.
+    "//clang",
+  ]
+  sources = [
+    "ClangMoveTests.cpp",
+  ]
+}

llvm/trunk/utils/gn/secondary/clang-tools-extra/unittests/clang-query/BUILD.gn

+import("//llvm/utils/unittest/unittest.gni")
+
+unittest("ClangQueryTests") {
+  configs += [ "//llvm/utils/gn/build:clang_code" ]
+  deps = [
+    "//clang-tools-extra/clang-query",
+    "//clang/lib/AST",
+    "//clang/lib/ASTMatchers",
+    "//clang/lib/ASTMatchers/Dynamic",
+    "//clang/lib/Basic",
+    "//clang/lib/Frontend",
+    "//clang/lib/Serialization",
+    "//clang/lib/Tooling",
+    "//llvm/lib/Support",
+  ]
+  include_dirs = [ "//clang-tools-extra/clang-query" ]
+  sources = [
+    "QueryEngineTest.cpp",
+    "QueryParserTest.cpp",
+  ]
+}

llvm/trunk/utils/gn/secondary/clang-tools-extra/unittests/clang-tidy/BUILD.gn

+import("//llvm/utils/unittest/unittest.gni")
+
+unittest("ClangTidyTests") {
+  configs += [ "//llvm/utils/gn/build:clang_code" ]
+  deps = [
+    "//clang-tools-extra/clang-tidy",
+    "//clang-tools-extra/clang-tidy/android",
+    "//clang-tools-extra/clang-tidy/google",
+    "//clang-tools-extra/clang-tidy/llvm",
+    "//clang-tools-extra/clang-tidy/objc",
+    "//clang-tools-extra/clang-tidy/readability",
+    "//clang-tools-extra/clang-tidy/utils",
+    "//clang/lib/AST",
+    "//clang/lib/ASTMatchers",
+    "//clang/lib/Basic",
+    "//clang/lib/Frontend",
+    "//clang/lib/Lex",
+    "//clang/lib/Serialization",
+    "//clang/lib/Tooling",
+    "//clang/lib/Tooling/Core",
+    "//llvm/lib/Support",
+  ]
+  include_dirs = [ "//clang-tools-extra/clang-tidy" ]
+  sources = [
+    "ClangTidyDiagnosticConsumerTest.cpp",
+    "ClangTidyOptionsTest.cpp",
+    "GoogleModuleTest.cpp",
+    "IncludeInserterTest.cpp",
+    "LLVMModuleTest.cpp",
+    "NamespaceAliaserTest.cpp",
+    "ObjCModuleTest.cpp",
+    "OverlappingReplacementsTest.cpp",
+    "ReadabilityModuleTest.cpp",
+    "UsingInserterTest.cpp",
+  ]
+}

llvm/trunk/utils/gn/secondary/clang-tools-extra/unittests/clangd/BUILD.gn

+import("//llvm/utils/unittest/unittest.gni")
+
+unittest("ClangdTests") {
+  configs += [ "//llvm/utils/gn/build:clang_code" ]
+  deps = [
+    "//clang-tools-extra/clang-tidy",
+    "//clang-tools-extra/clangd",
+    "//clang-tools-extra/clangd/refactor/tweaks",
+    "//clang/lib/AST",
+    "//clang/lib/Basic",
+    "//clang/lib/Format",
+    "//clang/lib/Frontend",
+    "//clang/lib/Index",
+    "//clang/lib/Lex",
+    "//clang/lib/Sema",
+    "//clang/lib/Serialization",
+    "//clang/lib/Tooling",
+    "//clang/lib/Tooling/Core",
+    "//clang/lib/Tooling/Inclusions",
+    "//llvm/lib/Support",
+    "//llvm/lib/Testing/Support",
+  ]
+  include_dirs = [ "//clang-tools-extra/clangd" ]
+  sources = [
+    "Annotations.cpp",
+    "BackgroundIndexTests.cpp",
+    "CancellationTests.cpp",
+    "ClangdTests.cpp",
+    "ClangdUnitTests.cpp",
+    "CodeCompleteTests.cpp",
+    "CodeCompletionStringsTests.cpp",
+    "ContextTests.cpp",
+    "DexTests.cpp",
+    "DiagnosticsTests.cpp",
+    "DraftStoreTests.cpp",
+    "ExpectedTypeTest.cpp",
+    "FSTests.cpp",
+    "FileDistanceTests.cpp",
+    "FileIndexTests.cpp",
+    "FindSymbolsTests.cpp",
+    "FunctionTests.cpp",
+    "FuzzyMatchTests.cpp",
+    "GlobalCompilationDatabaseTests.cpp",
+    "HeadersTests.cpp",
+    "IndexActionTests.cpp",
+    "IndexTests.cpp",
+    "JSONTransportTests.cpp",
+    "QualityTests.cpp",
+    "RIFFTests.cpp",
+    "SelectionTests.cpp",
+    "SerializationTests.cpp",
+    "SourceCodeTests.cpp",
+    "SymbolCollectorTests.cpp",
+    "SymbolInfoTests.cpp",
+    "SyncAPI.cpp",
+    "TUSchedulerTests.cpp",
+    "TestFS.cpp",
+    "TestIndex.cpp",
+    "TestTU.cpp",
+    "ThreadingTests.cpp",
+    "TraceTests.cpp",
+    "TweakTests.cpp",
+    "TypeHierarchyTests.cpp",
+    "URITests.cpp",
+    "XRefsTests.cpp",
+  ]
+}