Add const children() accessors to all AST nodes.
Previously, only Exprs had const accessors.
Details
Diff Detail
- Repository
- rC Clang
Event Timeline
+1. I wanted to do this but never bothered. Did you go over all the statements on Stmt.h systematically ? You could also do the same thing for all of the statements/expressions in StmtCXX.h, Expr.h, ExprCXX.h, and so on. Apart from this did you run clang-format on the patch ?
Yes.
You could also do the same thing for all of the statements/expressions in StmtCXX.h, Expr.h, ExprCXX.h, and so on.
I will go over those soon. I believe that Expr.h is mostly done.
Apart from this did you run clang-format on the patch ?
I tried to stick to the style of the non-const functions, even when it was wrong. I will clang-format the next patch!
Sorry for the delay. Thanks a lot for the patch!
Some of these casts are rather questionable. However this has nothing to do with your patch since you are just adding the const-qualified version of children(). Therefore I believe this patch looks good. Do you want me to commit it for you ?