Page MenuHomePhabricator

AMDGPU: Remove dx10-clamp from subtarget features
ClosedPublic

Authored by arsenm on Mar 29 2019, 11:00 AM.

Details

Summary

Since this can be set with s_setreg*, it should not be a subtarget
property. Set a default based on the calling convention, and Introduce
a new amdgpu-dx10-clamp attribute to override this if desired.

Also introduce a new amdgpu-ieee attribute to match.

The values need to match to allow inlining. I think it is OK for the
caller's dx10-clamp attribute to override the callee, but there
doesn't appear to be the infrastructure to do this currently without
definining the attribute in the generic Attributes.td.

Eventually the calling convention lowering will need to insert a mode
switch somewhere for these.

Diff Detail

Event Timeline

arsenm created this revision.Mar 29 2019, 11:00 AM
rampitec accepted this revision.Mar 29 2019, 11:21 AM

LGTM

lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
503

signaling in one word?

This revision is now accepted and ready to land.Mar 29 2019, 11:21 AM
arsenm closed this revision.Mar 29 2019, 12:13 PM
arsenm marked an inline comment as done.

r357302