This is an archive of the discontinued LLVM Phabricator instance.

Parallel STL version updated
AbandonedPublic

Authored by ldionne on Mar 28 2019, 6:14 AM.

Details

Summary

PSTL_VERSION 203 - > PSTL_VERSION 205

Diff Detail

Repository
rPSTL pstl

Event Timeline

MikeDvorskiy created this revision.Mar 28 2019, 6:14 AM

What determines the version? This doesn't seem to be tied to any LLVM release, is it?

Yes,... I doubted that is relevant to LLVM release.. and so as the some other macros form pstl_config.h
But as far as pstl_config.h is, PSTL_VERSION may be useful, at least to differ major changes, I guess...

We should talk about it, but we could consider tying versions of the PSTL to versions of LLVM. Or maybe some other scheme makes more sense. But I'm sure we can come up with something more useful than just a random number!

Eugene.Zelenko added inline comments.
include/pstl/internal/pstl_config.h
1

I think -*- C++ -*- should be merged into next line. See LLVM and Clang headers as example.

dexonsmith added inline comments.Mar 28 2019, 5:45 PM
include/pstl/internal/pstl_config.h
1

That's correct, but it's also unrelated to this commit. I would suggest fixing it separately.

ldionne commandeered this revision.Sep 15 2020, 5:41 AM
ldionne edited reviewers, added: MikeDvorskiy; removed: ldionne.

This review isn't relevant anymore, the _PSTL_VERSION is now tied to LLVM's version.

ldionne abandoned this revision.Sep 15 2020, 5:41 AM

Abandoned to clear up the review queue.