This is an archive of the discontinued LLVM Phabricator instance.

[ObjectFileMachO] Disable memory caching for savecore.
ClosedPublic

Authored by davide on Mar 27 2019, 11:57 AM.

Diff Detail

Event Timeline

davide created this revision.Mar 27 2019, 11:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2019, 11:57 AM
davide removed rL LLVM as the repository for this revision.Mar 27 2019, 12:22 PM
davide edited projects, added Restricted Project; removed Restricted Project.
davide removed a subscriber: llvm-commits.
jasonmolenda accepted this revision.Mar 27 2019, 4:05 PM

Looks good. Removing that printf is good. Could you also remove the printf("mach_header:...") in the same function?

It would be nice if include/lldb/Target/Process.h had the decl for ReadMemoryFromInferior right after ReadMemory(), and a comment that ReadMemoryFromInferior does not go through the memory cache (and most callers should go through ReadMemory()) so people know what the difference is.

This revision is now accepted and ready to land.Mar 27 2019, 4:05 PM

Looks good. Removing that printf is good. Could you also remove the printf("mach_header:...") in the same function?

It would be nice if include/lldb/Target/Process.h had the decl for ReadMemoryFromInferior right after ReadMemory(), and a comment that ReadMemoryFromInferior does not go through the memory cache (and most callers should go through ReadMemory()) so people know what the difference is.

I'll do that as a follow-up. Thank you Jason!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2019, 5:05 PM

Done.

$ git llvm push
Pushing 3 commits:
  d3e193e68a7 [ObjectFileMachO] Disable memory caching for savecore.
  10502683510 [ObjectFileMachO] Remove another debugging aid.
  a619d7b69b9 [Process] Reorder declarations and document ReadMemoryFromInferior.
Sending        lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
Transmitting file data .done
Committing transaction...
Committed revision 357134.
Committed d3e193e68a7 to svn.
Sending        lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
Transmitting file data .done
Committing transaction...
Committed revision 357135.
Committed 10502683510 to svn.
Sending        lldb/trunk/include/lldb/Target/Process.h
Transmitting file data .done
Committing transaction...
Committed revision 357136.
Committed a619d7b69b9 to svn.