This is an archive of the discontinued LLVM Phabricator instance.

[opt-viewer] Teach optrecord.py about !Failure tags
ClosedPublic

Authored by paquette on Mar 27 2019, 11:27 AM.

Reviewers

Commits

Summary

WarnMissedTransforms.cpp produces remarks that use !Failure tags.

These weren't supported in optrecord.py, so if you encountered one in any of the tools, the tool would crash.

Add them as a type of missed optimization.

LGTM.

This revision is now accepted and ready to land.Mar 27 2019, 11:32 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

tools/

opt-viewer/

2 lines

	Show First 20 Lines • Show All 258 Lines • ▼ Show 20 Lines

	class Missed(Remark):			class Missed(Remark):
	yaml_tag = '!Missed'			yaml_tag = '!Missed'

	@property			@property
	def color(self):			def color(self):
	return "red"			return "red"

				class Failure(Missed):
				yaml_tag = '!Failure'

	def get_remarks(input_file, filter_=None):			def get_remarks(input_file, filter_=None):
	max_hotness = 0			max_hotness = 0
	all_remarks = dict()			all_remarks = dict()
	file_remarks = defaultdict(functools.partial(defaultdict, list))			file_remarks = defaultdict(functools.partial(defaultdict, list))

	with open(input_file) as f:			with open(input_file) as f:
	docs = yaml.load_all(f, Loader=Loader)			docs = yaml.load_all(f, Loader=Loader)
	▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines