Page MenuHomePhabricator

AMDGPU: Add additional MIR tests for exec mask optimizations
ClosedPublic

Authored by arsenm on Mar 25 2019, 7:55 AM.

Details

Reviewers
rampitec
Summary

Also includes one example of how this transform is unsound. This isn't
verifying the copies are used in the control flow intrinisic patterns.

Also add option to disable exec mask opt pass Since this pass is
unsound, it may be useful to turn it off until it is fixed.

Diff Detail

Event Timeline

arsenm created this revision.Mar 25 2019, 7:55 AM
rampitec requested changes to this revision.Mar 25 2019, 10:22 AM
rampitec added inline comments.
lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
890–895

This should not what when option is disabled.

This revision now requires changes to proceed.Mar 25 2019, 10:22 AM
arsenm updated this revision to Diff 192155.Mar 25 2019, 10:58 AM

Change insert point for memory clause when disabled

This revision is now accepted and ready to land.Mar 25 2019, 11:02 AM
arsenm closed this revision.Mar 27 2019, 9:57 AM

r357091