This is an archive of the discontinued LLVM Phabricator instance.

Differential D59660

Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS.
ClosedPublic

Authored by delcypher on Mar 21 2019, 11:54 AM.

Details

Reviewers
kubamracek
yln
serge-sans-paille
Commits
rCRT356701: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS.
rG5988d72243bc: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS.
rL356701: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS.
Summary

To make this test pass it was necesary to change iossim_run.py to
propagate the ASAN_ACTIVATION_OPTIONS environment variable into the
testing environment.

rdar://problem/49114807

Diff Detail

Repository
rL LLVM

Event Timeline

delcypher created this revision.Mar 21 2019, 11:54 AM
Herald added a reviewer: serge-sans-paille. · View Herald TranscriptMar 21 2019, 11:54 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added a subscriber: Restricted Project. · View Herald Transcript
delcypher removed a reviewer: serge-sans-paille.Mar 21 2019, 11:54 AM
Herald added a reviewer: serge-sans-paille. · View Herald TranscriptMar 21 2019, 11:54 AM
Harbormaster completed remote builds in B29450: Diff 191757.Mar 21 2019, 11:55 AM
yln added a comment.Mar 21 2019, 12:04 PM

LGTM. Thanks!

yln accepted this revision.Mar 21 2019, 12:04 PM
This revision is now accepted and ready to land.Mar 21 2019, 12:04 PM
Closed by commit rL356701: Enable `asan/TestCases/Posix/start-deactivated.cc` test for iOS. (authored by delcypher). · Explain WhyMar 21 2019, 12:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
test/
asan/
TestCases/
Posix/
1 line
sanitizer_common/
ios_commands/
2 lines

Diff 191762

compiler-rt/trunk/test/asan/TestCases/Posix/start-deactivated.cc

Show All 12 Lines
// RUN: ASAN_ACTIVATION_OPTIONS=help=1,handle_segv=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-UNSUPPORTED // RUN: ASAN_ACTIVATION_OPTIONS=help=1,handle_segv=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-UNSUPPORTED
// RUN: %env_asan_opts=start_deactivated=1 \ // RUN: %env_asan_opts=start_deactivated=1 \
// RUN: ASAN_ACTIVATION_OPTIONS=help=1,handle_segv=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-UNSUPPORTED-V0 // RUN: ASAN_ACTIVATION_OPTIONS=help=1,handle_segv=0 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-UNSUPPORTED-V0
// Check that verbosity=1 in activation flags affects reporting of unrecognized activation flags. // Check that verbosity=1 in activation flags affects reporting of unrecognized activation flags.
// RUN: %env_asan_opts=start_deactivated=1 \ // RUN: %env_asan_opts=start_deactivated=1 \
// RUN: ASAN_ACTIVATION_OPTIONS=help=1,handle_segv=0,verbosity=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-UNSUPPORTED // RUN: ASAN_ACTIVATION_OPTIONS=help=1,handle_segv=0,verbosity=1 not %run %t 2>&1 | FileCheck %s --check-prefix=CHECK-UNSUPPORTED
// UNSUPPORTED: ios
// END. // END.
#if !defined(SHARED_LIB) #if !defined(SHARED_LIB)
#include <assert.h> #include <assert.h>
#include <dlfcn.h> #include <dlfcn.h>
#include <stdio.h> #include <stdio.h>
▲ Show 20 Lines • Show All 117 Lines • Show Last 20 Lines

compiler-rt/trunk/test/sanitizer_common/ios_commands/iossim_run.py

#!/usr/bin/python #!/usr/bin/python
import glob, os, pipes, sys, subprocess import glob, os, pipes, sys, subprocess
if not "SANITIZER_IOSSIM_TEST_DEVICE_IDENTIFIER" in os.environ: if not "SANITIZER_IOSSIM_TEST_DEVICE_IDENTIFIER" in os.environ:
raise EnvironmentError("Specify SANITIZER_IOSSIM_TEST_DEVICE_IDENTIFIER to select which simulator to use.") raise EnvironmentError("Specify SANITIZER_IOSSIM_TEST_DEVICE_IDENTIFIER to select which simulator to use.")
device_id = os.environ["SANITIZER_IOSSIM_TEST_DEVICE_IDENTIFIER"] device_id = os.environ["SANITIZER_IOSSIM_TEST_DEVICE_IDENTIFIER"]
for e in ["ASAN_OPTIONS", "TSAN_OPTIONS", "UBSAN_OPTIONS", "APPLE_ASAN_INIT_FOR_DLOPEN"]: for e in ["ASAN_OPTIONS", "TSAN_OPTIONS", "UBSAN_OPTIONS", "APPLE_ASAN_INIT_FOR_DLOPEN", "ASAN_ACTIVATION_OPTIONS"]:
if e in os.environ: if e in os.environ:
os.environ["SIMCTL_CHILD_" + e] = os.environ[e] os.environ["SIMCTL_CHILD_" + e] = os.environ[e]
prog = sys.argv[1] prog = sys.argv[1]
exit_code = None exit_code = None
if prog == 'rm': if prog == 'rm':
# The simulator and host actually share the same file system so we can just # The simulator and host actually share the same file system so we can just
# execute directly on the host. # execute directly on the host.
Show All 17 Lines