This is an archive of the discontinued LLVM Phabricator instance.

Differential D59583

python2/3 compat: exceptions
ClosedPublic

Authored by serge-sans-paille on Mar 20 2019, 12:24 AM.

Details

Reviewers
michaelplatings
labath
Commits
rG3577da766719: Portable exception value access across Python 2 / Python 3
rLLDB356670: Portable exception value access across Python 2 / Python 3
rL356670: Portable exception value access across Python 2 / Python 3

Diff Detail

Repository
rL LLVM

Event Timeline

serge-sans-paille created this revision.Mar 20 2019, 12:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2019, 12:24 AM
Herald added subscribers: lldb-commits, jdoerfert. · View Herald Transcript
labath accepted this revision.Mar 20 2019, 5:29 AM
This revision is now accepted and ready to land.Mar 20 2019, 5:29 AM
Closed by commit rL356670: Portable exception value access across Python 2 / Python 3 (authored by serge_sans_paille). · Explain WhyMar 21 2019, 7:38 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2019, 7:38 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
lldb/
trunk/
examples/
python/
2 lines

Diff 191688

lldb/trunk/examples/python/crashlog.py

Show First 20 Lines • Show All 278 Lines • ▼ Show 20 Lines class DarwinImage(symbolication.Image):
if os.path.exists(self.dsymForUUIDBinary): if os.path.exists(self.dsymForUUIDBinary):
dsym_for_uuid_command = '%s %s' % ( dsym_for_uuid_command = '%s %s' % (
self.dsymForUUIDBinary, uuid_str) self.dsymForUUIDBinary, uuid_str)
s = subprocess.check_output(dsym_for_uuid_command, shell=True) s = subprocess.check_output(dsym_for_uuid_command, shell=True)
if s: if s:
try: try:
plist_root = plistlib.readPlistFromString(s) plist_root = plistlib.readPlistFromString(s)
except: except:
print(("Got exception: ", sys.exc_value, " handling dsymForUUID output: \n", s)) print(("Got exception: ", sys.exc_info()[1], " handling dsymForUUID output: \n", s))
raise raise
if plist_root: if plist_root:
plist = plist_root[uuid_str] plist = plist_root[uuid_str]
if plist: if plist:
if 'DBGArchitecture' in plist: if 'DBGArchitecture' in plist:
self.arch = plist['DBGArchitecture'] self.arch = plist['DBGArchitecture']
if 'DBGDSYMPath' in plist: if 'DBGDSYMPath' in plist:
self.symfile = os.path.realpath( self.symfile = os.path.realpath(
▲ Show 20 Lines • Show All 737 Lines • Show Last 20 Lines