Page MenuHomePhabricator

Mips: Don't create copy of nothing
ClosedPublic

Authored by arsenm on Mar 19 2019, 10:08 PM.

Details

Reviewers
atanasyan
sdardis
Summary

This was creating a copy of the register the pseudo itself was
def'ing, leaving a copy of an undefined register. I'm not sure how
the verifier is not catching this, but this avoids asserting in a
future change to RegAllocFast

Diff Detail

Event Timeline

arsenm created this revision.Mar 19 2019, 10:08 PM

The patch LGTM. SimonD, as far as I know you are an author of original patch D31287. Do you have any comments / objections against this fix?

sdardis accepted this revision.Mar 21 2019, 11:23 AM

Good catch. LGTM.

lib/Target/Mips/MipsISelLowering.cpp
1727

This can committed separately as it is a NFC.

This revision is now accepted and ready to land.Mar 21 2019, 11:23 AM
arsenm closed this revision.Mar 21 2019, 1:54 PM

r356716